From cbe2d2bcd1c7c247c552eb3856d6f592e550bb65 Mon Sep 17 00:00:00 2001 From: bms Date: Wed, 28 Feb 2007 21:58:37 +0000 Subject: Add comments about common idioms for cleanup pass at a later date. --- sys/netinet6/ip6_mroute.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'sys/netinet6/ip6_mroute.c') diff --git a/sys/netinet6/ip6_mroute.c b/sys/netinet6/ip6_mroute.c index 01bad3f..daab702 100644 --- a/sys/netinet6/ip6_mroute.c +++ b/sys/netinet6/ip6_mroute.c @@ -121,6 +121,7 @@ static MALLOC_DEFINE(M_MRTABLE6, "mf6c", "multicast forwarding cache entry"); +/* XXX: this is a very common idiom; move to ? */ #define M_HASCL(m) ((m)->m_flags & M_EXT) static int ip6_mdq __P((struct mbuf *, struct ifnet *, struct mf6c *)); @@ -253,6 +254,7 @@ static int pim6; /* * Macros to compute elapsed time efficiently * Borrowed from Van Jacobson's scheduling code + * XXX: replace with timersub() ? */ #define TV_DELTA(a, b, delta) do { \ int xxs; \ @@ -272,6 +274,7 @@ static int pim6; } \ } while (/*CONSTCOND*/ 0) +/* XXX: replace with timercmp(a, b, <) ? */ #define TV_LT(a, b) (((a).tv_usec < (b).tv_usec && \ (a).tv_sec <= (b).tv_sec) || (a).tv_sec < (b).tv_sec) -- cgit v1.1