From b9ef107414848cd42bfb431cc80e5187bdfb53fa Mon Sep 17 00:00:00 2001 From: tuexen Date: Tue, 27 Dec 2011 10:16:24 +0000 Subject: Address issues found by clang. While there, fix also some style issues. MFC after: 3 months. --- sys/netinet/sctp_sysctl.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'sys/netinet/sctp_sysctl.c') diff --git a/sys/netinet/sctp_sysctl.c b/sys/netinet/sctp_sysctl.c index 4716bab..0ae50f7 100644 --- a/sys/netinet/sctp_sysctl.c +++ b/sys/netinet/sctp_sysctl.c @@ -388,12 +388,12 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) /* request some more memory than needed */ req->oldidx = (n + n / 8); - return 0; + return (0); } if (req->newptr != USER_ADDR_NULL) { SCTP_INP_INFO_RUNLOCK(); SCTP_LTRACE_ERR_RET(NULL, NULL, NULL, SCTP_FROM_SCTP_SYSCTL, EPERM); - return EPERM; + return (EPERM); } LIST_FOREACH(inp, &SCTP_BASE_INFO(listhead), sctp_list) { SCTP_INP_RLOCK(inp); @@ -424,14 +424,14 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) error = SYSCTL_OUT(req, &xinpcb, sizeof(struct xsctp_inpcb)); if (error) { SCTP_INP_DECR_REF(inp); - return error; + return (error); } SCTP_INP_INFO_RLOCK(); SCTP_INP_RLOCK(inp); error = copy_out_local_addresses(inp, NULL, req); if (error) { SCTP_INP_DECR_REF(inp); - return error; + return (error); } LIST_FOREACH(stcb, &inp->sctp_asoc_list, sctp_tcblist) { SCTP_TCB_LOCK(stcb); @@ -475,7 +475,7 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) if (error) { SCTP_INP_DECR_REF(inp); atomic_subtract_int(&stcb->asoc.refcnt, 1); - return error; + return (error); } SCTP_INP_INFO_RLOCK(); SCTP_INP_RLOCK(inp); @@ -483,7 +483,7 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) if (error) { SCTP_INP_DECR_REF(inp); atomic_subtract_int(&stcb->asoc.refcnt, 1); - return error; + return (error); } TAILQ_FOREACH(net, &stcb->asoc.nets, sctp_next) { xraddr.last = 0; @@ -509,7 +509,7 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) if (error) { SCTP_INP_DECR_REF(inp); atomic_subtract_int(&stcb->asoc.refcnt, 1); - return error; + return (error); } SCTP_INP_INFO_RLOCK(); SCTP_INP_RLOCK(inp); @@ -522,7 +522,7 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) error = SYSCTL_OUT(req, &xraddr, sizeof(struct xsctp_raddr)); if (error) { SCTP_INP_DECR_REF(inp); - return error; + return (error); } SCTP_INP_INFO_RLOCK(); SCTP_INP_RLOCK(inp); @@ -534,7 +534,7 @@ sctp_assoclist(SYSCTL_HANDLER_ARGS) xstcb.last = 1; error = SYSCTL_OUT(req, &xstcb, sizeof(struct xsctp_tcb)); if (error) { - return error; + return (error); } skip: SCTP_INP_INFO_RLOCK(); @@ -544,7 +544,7 @@ skip: memset((void *)&xinpcb, 0, sizeof(struct xsctp_inpcb)); xinpcb.last = 1; error = SYSCTL_OUT(req, &xinpcb, sizeof(struct xsctp_inpcb)); - return error; + return (error); } -- cgit v1.1