From 591e129226ccdb979c1e1344a0a573431f4c297b Mon Sep 17 00:00:00 2001 From: piso Date: Sat, 7 Apr 2007 09:52:36 +0000 Subject: Prevent the usage of an uninitialized variable: do not accept StartMediaTx message before an OpnRcvChnAck message was received. Reviewed by: glebius Approved by: glebius (mentor) MFC after: 3 days Found with: Coverity Prevent(tm) CID: 498 --- sys/netinet/libalias/alias_skinny.c | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'sys/netinet/libalias') diff --git a/sys/netinet/libalias/alias_skinny.c b/sys/netinet/libalias/alias_skinny.c index 91307ac..e726e55 100644 --- a/sys/netinet/libalias/alias_skinny.c +++ b/sys/netinet/libalias/alias_skinny.c @@ -309,6 +309,7 @@ AliasHandleSkinny(struct libalias *la, struct ip *pip, struct alias_link *lnk) size_t orig_len, skinny_hdr_len = sizeof(struct skinny_header); ConvDirection direction; + lip = -1; tc = (struct tcphdr *)ip_next(pip); hlen = (pip->ip_hl + tc->th_off) << 2; tlen = ntohs(pip->ip_len); @@ -418,6 +419,16 @@ AliasHandleSkinny(struct libalias *la, struct ip *pip, struct alias_link *lnk) #endif return; } + if (lip == -1) { +#ifdef LIBALIAS_DEBUG + fprintf(stderr, + "PacketAlias/Skinny: received a" + " packet,StartMediaTx Message before" + " packet,OpnRcvChnAckMsg\n" +#endif + return; + } + #ifdef LIBALIAS_DEBUG fprintf(stderr, "PacketAlias/Skinny: Received start media trans msg\n"); -- cgit v1.1