From 3c69856ec59055937844e49a3b20699d15b2bdfc Mon Sep 17 00:00:00 2001 From: glebius Date: Mon, 18 Oct 2004 20:13:57 +0000 Subject: Major overhaul. List of functional changes: - Make a single device per single node with a single hook. This gives us parrallelizm, which can't be achieved on a single node with many devices/hooks. This also gives us flexibility - we can play with a particular device node, not affecting others. - Remove read queue as it is. Use struct ifqueue instead. This change removes a lot of extra memcpy()ing, m_devget()ting and m_copymem()ming. In ng_device_receivedata() we enqueue an mbuf and wake readers. In ngdread() we take one mbuf from qeueue and uiomove() it to userspace. If no mbuf is present we optionally block. [1] - In ngdwrite() we create an mbuf from uio using m_uiotombuf(). This is faster then uiomove() into buffer, and then m_copydata(), and this is much better than huge m_pullup(). - Perform locking of device - Perform locking of connection list. - Clear out _rcvmsg method, since it does nothing good yet. - Implement NGM_DEVICE_GET_DEVNAME message. - #if 0 ioctl method, while nothing is done here yet. - Return immediately from ngdwrite() if uio_resid == 0. List of tidyness changes: - Introduce device2priv(), to remove cut'n'paste. - Use MALLOC/FREE, instead of malloc/free. - Use unit2minor(). - Use UID_ROOT/GID_WHEEL instead of 0/0. - Define NGD_DEVICE_DEVNAME, use it. - Use more nice macros for debugging. [2] - Return Exxx, not -1. style(9) changes: - No "#endif" after short block. - Break long lines. - Remove extra spaces, add needed spaces. [1] Obtained from: if_tun.c [2] Obtained from: ng_pppoe.c Reviewed by: marks Approved by: julian (mentor) MFC after: 1 month --- sys/modules/netgraph/device/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sys/modules/netgraph') diff --git a/sys/modules/netgraph/device/Makefile b/sys/modules/netgraph/device/Makefile index 9f85151..92eaa98 100644 --- a/sys/modules/netgraph/device/Makefile +++ b/sys/modules/netgraph/device/Makefile @@ -2,6 +2,6 @@ KMOD= ng_device SRCS= ng_device.c -SRCS+= device_if.h +SRCS+= device_if.h vnode_if.h .include -- cgit v1.1