From 4efdef565f9a0ca3468534f97c6ac4aaaf747c9a Mon Sep 17 00:00:00 2001 From: ed Date: Sat, 27 Sep 2008 08:51:18 +0000 Subject: Replace all calls to minor() with dev2unit(). After I removed all the unit2minor()/minor2unit() calls from the kernel yesterday, I realised calling minor() everywhere is quite confusing. Character devices now only have the ability to store a unit number, not a minor number. Remove the confusion by using dev2unit() everywhere. This commit could also be considered as a bug fix. A lot of drivers call minor(), while they should actually be calling dev2unit(). In -CURRENT this isn't a problem, but it turns out we never had any problem reports related to that issue in the past. I suspect not many people connect more than 256 pieces of the same hardware. Reviewed by: kib --- sys/mips/mips/mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sys/mips') diff --git a/sys/mips/mips/mem.c b/sys/mips/mips/mem.c index 04cc937..53fe634 100644 --- a/sys/mips/mips/mem.c +++ b/sys/mips/mips/mem.c @@ -93,7 +93,7 @@ memrw(dev, uio, flags) } /* minor device 0 is physical memory */ - if (minor(dev) == CDEV_MINOR_MEM) { + if (dev2unit(dev) == CDEV_MINOR_MEM) { v = uio->uio_offset; c = iov->iov_len; @@ -130,7 +130,7 @@ memrw(dev, uio, flags) } /* minor device 1 is kernel memory */ - else if (minor(dev) == CDEV_MINOR_KMEM) { + else if (dev2unit(dev) == CDEV_MINOR_KMEM) { v = uio->uio_offset; c = min(iov->iov_len, MAXPHYS); vm_offset_t addr, eaddr; -- cgit v1.1