From 83154f853d9ca39deb1add01e032aff1f0678514 Mon Sep 17 00:00:00 2001 From: tegge Date: Tue, 26 Sep 2006 04:12:49 +0000 Subject: Use mount interlock to protect all changes to mnt_flag and mnt_kern_flag. This eliminates a race where MNT_UPDATE flag could be lost when nmount() raced against sync(), sync_fsync() or quotactl(). --- sys/kern/vfs_subr.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'sys/kern/vfs_subr.c') diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 2903e7d..72c4b5c 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -3081,12 +3081,16 @@ sync_fsync(struct vop_fsync_args *ap) vfs_unbusy(mp, td); return (0); } + MNT_ILOCK(mp); asyncflag = mp->mnt_flag & MNT_ASYNC; mp->mnt_flag &= ~MNT_ASYNC; + MNT_IUNLOCK(mp); vfs_msync(mp, MNT_NOWAIT); error = VFS_SYNC(mp, MNT_LAZY, td); + MNT_ILOCK(mp); if (asyncflag) mp->mnt_flag |= MNT_ASYNC; + MNT_IUNLOCK(mp); vn_finished_write(mp); vfs_unbusy(mp, td); return (error); -- cgit v1.1