From 6a5dc97620c08ad609e1b3c3c042f150feb46dd3 Mon Sep 17 00:00:00 2001 From: phk Date: Mon, 31 May 1999 11:29:30 +0000 Subject: Simplify cdevsw registration. The cdevsw_add() function now finds the major number(s) in the struct cdevsw passed to it. cdevsw_add_generic() is no longer needed, cdevsw_add() does the same thing. cdevsw_add() will print an message if the d_maj field looks bogus. Remove nblkdev and nchrdev variables. Most places they were used bogusly. Instead check a dev_t for validity by seeing if devsw() or bdevsw() returns NULL. Move bdevsw() and devsw() functions to kern/kern_conf.c Bump __FreeBSD_version to 400006 This commit removes: 72 bogus makedev() calls 26 bogus SYSINIT functions if_xe.c bogusly accessed cdevsw[], author/maintainer please fix. I4b and vinum not changed. Patches emailed to authors. LINT probably broken until they catch up. --- sys/gnu/i386/isa/dgb.c | 22 ++++------------------ sys/gnu/i386/isa/dgm.c | 23 +++++------------------ 2 files changed, 9 insertions(+), 36 deletions(-) (limited to 'sys/gnu/i386') diff --git a/sys/gnu/i386/isa/dgb.c b/sys/gnu/i386/isa/dgb.c index b39c89d..e16c979 100644 --- a/sys/gnu/i386/isa/dgb.c +++ b/sys/gnu/i386/isa/dgb.c @@ -1,5 +1,5 @@ /*- - * dgb.c $Id: dgb.c,v 1.48 1999/05/08 07:02:24 phk Exp $ + * dgb.c $Id: dgb.c,v 1.49 1999/05/30 16:51:56 phk Exp $ * * Digiboard driver. * @@ -425,7 +425,10 @@ dgbprobe(dev) int i, v; u_long win_size; /* size of vizible memory window */ int unit=dev->id_unit; + static int once; + if (!once++) + cdevsw_add(&dgb_cdevsw); sc->unit=dev->id_unit; sc->port=dev->id_iobase; @@ -2301,21 +2304,4 @@ disc_optim(tp, t) tp->t_state &= ~TS_CAN_BYPASS_L_RINT; } - -static int dgb_devsw_installed; - -static void -dgb_drvinit(void *unused) -{ - dev_t dev; - - if( ! dgb_devsw_installed ) { - dev = makedev(CDEV_MAJOR, 0); - cdevsw_add(&dev,&dgb_cdevsw, NULL); - dgb_devsw_installed = 1; - } -} - -SYSINIT(dgbdev,SI_SUB_DRIVERS,SI_ORDER_MIDDLE+CDEV_MAJOR,dgb_drvinit,NULL) - #endif /* NDGB > 0 */ diff --git a/sys/gnu/i386/isa/dgm.c b/sys/gnu/i386/isa/dgm.c index 5f3ff63..6fa36ba 100644 --- a/sys/gnu/i386/isa/dgm.c +++ b/sys/gnu/i386/isa/dgm.c @@ -1,5 +1,5 @@ /*- - * $Id: dgm.c,v 1.13 1999/05/08 07:02:25 phk Exp $ + * $Id: dgm.c,v 1.14 1999/05/30 16:51:58 phk Exp $ * * This driver and the associated header files support the ISA PC/Xem * Digiboards. Its evolutionary roots are described below. @@ -397,6 +397,10 @@ dgmprobe(dev) struct dgm_softc *sc= &dgm_softc[dev->id_unit]; int i, v; int unit=dev->id_unit; + static int once; + + if (!once++) + cdevsw_add(&dgm_cdevsw); sc->unit=dev->id_unit; sc->port=dev->id_iobase; @@ -2105,21 +2109,4 @@ disc_optim(tp, t) tp->t_state &= ~TS_CAN_BYPASS_L_RINT; } - -static int dgm_devsw_installed; - -static void -dgm_drvinit(void *unused) -{ - dev_t dev; - - if( ! dgm_devsw_installed ) { - dev = makedev(CDEV_MAJOR, 0); - cdevsw_add(&dev,&dgm_cdevsw, NULL); - dgm_devsw_installed = 1; - } -} - -SYSINIT(dgmdev,SI_SUB_DRIVERS,SI_ORDER_MIDDLE+CDEV_MAJOR,dgm_drvinit,NULL) - #endif /* NDGM > 0 */ -- cgit v1.1