From 177754802c82adf2c6928cda80086b32ccd1e8eb Mon Sep 17 00:00:00 2001 From: kib Date: Mon, 24 Oct 2011 13:53:32 +0000 Subject: The only possible error return from null_nodeget() is due to insmntque1 failure (the getnewvnode cannot return an error). In this case, the null_insmntque_dtr() already unlocked the reclaimed vnode, so VOP_UNLOCK() in the nullfs_mount() after null_nodeget() failure is wrong. Tested by: pho MFC after: 1 week --- sys/fs/nullfs/null_vfsops.c | 1 - 1 file changed, 1 deletion(-) (limited to 'sys/fs') diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c index 7eaffe5..fd20151 100644 --- a/sys/fs/nullfs/null_vfsops.c +++ b/sys/fs/nullfs/null_vfsops.c @@ -157,7 +157,6 @@ nullfs_mount(struct mount *mp) * Make sure the node alias worked */ if (error) { - VOP_UNLOCK(vp, 0); vrele(lowerrootvp); free(xmp, M_NULLFSMNT); /* XXX */ return (error); -- cgit v1.1