From 5012e4bd24ba7188c76c8a4967032bb087a6caca Mon Sep 17 00:00:00 2001 From: kib Date: Fri, 1 Feb 2013 16:57:02 +0000 Subject: Assert that the mbuf in the chain has sane length. Proper place for this check is somewhere in the network code, but this assertion already proven to be useful in catching what seems to be driver bugs causing NFS scrambling random memory. Discussed with: rmacklem MFC after: 1 week --- sys/fs/nfs/nfs_commonsubs.c | 1 + 1 file changed, 1 insertion(+) (limited to 'sys/fs/nfs') diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c index efc0786..b2d74c7 100644 --- a/sys/fs/nfs/nfs_commonsubs.c +++ b/sys/fs/nfs/nfs_commonsubs.c @@ -218,6 +218,7 @@ nfsm_mbufuio(struct nfsrv_descript *nd, struct uio *uiop, int siz) } mbufcp = NFSMTOD(mp, caddr_t); len = mbuf_len(mp); + KASSERT(len > 0, ("len %d", len)); } xfer = (left > len) ? len : left; #ifdef notdef -- cgit v1.1