From f7e588347b3192f4351b4e27c498cc085021b6e4 Mon Sep 17 00:00:00 2001 From: jeff Date: Wed, 25 Sep 2002 02:32:42 +0000 Subject: - Use vrefcnt() where it is safe to do so instead of doing direct and unlocked accesses to v_usecount. - Lock access to the buf lists in the various sync routines. interlock locking could be avoided almost entirely in leaf filesystems if the fsync function had a generic helper. --- sys/fs/hpfs/hpfs_vnops.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'sys/fs/hpfs/hpfs_vnops.c') diff --git a/sys/fs/hpfs/hpfs_vnops.c b/sys/fs/hpfs/hpfs_vnops.c index b862bad..c3ddec5 100644 --- a/sys/fs/hpfs/hpfs_vnops.c +++ b/sys/fs/hpfs/hpfs_vnops.c @@ -95,11 +95,15 @@ hpfs_fsync(ap) * Flush all dirty buffers associated with a vnode. */ loop: + VI_LOCK(vp); s = splbio(); for (bp = TAILQ_FIRST(&vp->v_dirtyblkhd); bp; bp = nbp) { nbp = TAILQ_NEXT(bp, b_vnbufs); - if (BUF_LOCK(bp, LK_EXCLUSIVE | LK_NOWAIT)) + VI_UNLOCK(vp); + if (BUF_LOCK(bp, LK_EXCLUSIVE | LK_NOWAIT)) { + VI_LOCK(vp); continue; + } if ((bp->b_flags & B_DELWRI) == 0) panic("hpfs_fsync: not dirty"); bremfree(bp); @@ -107,19 +111,18 @@ loop: (void) bwrite(bp); goto loop; } - VI_LOCK(vp); while (vp->v_numoutput) { vp->v_iflag |= VI_BWAIT; msleep((caddr_t)&vp->v_numoutput, VI_MTX(vp), PRIBIO + 1, "hpfsn", 0); } - VI_UNLOCK(vp); #ifdef DIAGNOSTIC if (!TAILQ_EMPTY(&vp->v_dirtyblkhd)) { vprint("hpfs_fsync: dirty", vp); goto loop; } #endif + VI_UNLOCK(vp); splx(s); /* @@ -604,7 +607,7 @@ hpfs_inactive(ap) return (error); } - if (prtactive && vp->v_usecount != 0) + if (prtactive && vrefcnt(vp) != 0) vprint("hpfs_inactive: pushing active", vp); if (hp->h_flag & H_INVAL) { -- cgit v1.1