From 23ba01be794edbf1f9b407af953ad1d2261345b8 Mon Sep 17 00:00:00 2001 From: kan Date: Wed, 19 Nov 2003 04:14:42 +0000 Subject: Fix vnode locking in fdesc_setattr. Lock vnode before invoking VOP_SETATTR on it. Approved by: re@ (rwatson) --- sys/fs/fdescfs/fdesc_vnops.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'sys/fs/fdescfs') diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index a3e4c12..4f4ab54 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -395,12 +395,12 @@ fdesc_setattr(ap) return (error); } vp = fp->f_vnode; - if ((error = vn_start_write(vp, &mp, V_WAIT | PCATCH)) != 0) { - fdrop(fp, ap->a_td); - return (error); + vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, ap->a_td); + if ((error = vn_start_write(vp, &mp, V_WAIT | PCATCH)) == 0) { + error = VOP_SETATTR(vp, ap->a_vap, ap->a_cred, ap->a_td); + vn_finished_write(mp); } - error = VOP_SETATTR(vp, ap->a_vap, ap->a_cred, ap->a_td); - vn_finished_write(mp); + VOP_UNLOCK(vp, 0, ap->a_td); fdrop(fp, ap->a_td); return (error); } -- cgit v1.1