From ad73989e217fc422c2aef5d60cdf23baee9b9489 Mon Sep 17 00:00:00 2001 From: kib Date: Fri, 23 May 2008 16:36:39 +0000 Subject: When vget() fails (because the vnode has been reclaimed), there is no sense to loop trying to vget() the vnode again. PR: 122977 Submitted by: Arthur Hartwig Tested by: pho Reviewed by: jhb MFC after: 1 week --- sys/fs/devfs/devfs_vnops.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'sys/fs/devfs') diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c index 6c3f8fb..80f2dba 100644 --- a/sys/fs/devfs/devfs_vnops.c +++ b/sys/fs/devfs/devfs_vnops.c @@ -280,7 +280,6 @@ devfs_allocv(struct devfs_dirent *de, struct mount *mp, struct vnode **vpp, stru sx_xunlock(&dmp->dm_lock); return (ENOENT); } - loop: DEVFS_DE_HOLD(de); DEVFS_DMP_HOLD(dmp); mtx_lock(&devfs_de_interlock); @@ -296,8 +295,10 @@ devfs_allocv(struct devfs_dirent *de, struct mount *mp, struct vnode **vpp, stru vput(vp); return (ENOENT); } - else if (error) - goto loop; + else if (error) { + sx_xunlock(&dmp->dm_lock); + return (error); + } sx_xunlock(&dmp->dm_lock); *vpp = vp; return (0); -- cgit v1.1