From a246e10f55686681d4b6bd4dba5ca661b4e34bb0 Mon Sep 17 00:00:00 2001 From: phk Date: Mon, 20 Mar 2000 10:44:49 +0000 Subject: Remove B_READ, B_WRITE and B_FREEBUF and replace them with a new field in struct buf: b_iocmd. The b_iocmd is enforced to have exactly one bit set. B_WRITE was bogusly defined as zero giving rise to obvious coding mistakes. Also eliminate the redundant struct buf flag B_CALL, it can just as efficiently be done by comparing b_iodone to NULL. Should you get a panic or drop into the debugger, complaining about "b_iocmd", don't continue. It is likely to write on your disk where it should have been reading. This change is a step in the direction towards a stackable BIO capability. A lot of this patch were machine generated (Thanks to style(9) compliance!) Vinum users: Greg has not had time to test this yet, be careful. --- sys/dev/scd/scd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sys/dev/scd') diff --git a/sys/dev/scd/scd.c b/sys/dev/scd/scd.c index b6e9460..836dbc9 100644 --- a/sys/dev/scd/scd.c +++ b/sys/dev/scd/scd.c @@ -337,7 +337,7 @@ scdstrategy(struct buf *bp) } /* read only */ - if (!(bp->b_flags & B_READ)) { + if (!(bp->b_iocmd == BIO_READ)) { bp->b_error = EROFS; goto bad; } -- cgit v1.1