From 55bfc727adc4d17c3090622e123ba1718dd50ca5 Mon Sep 17 00:00:00 2001
From: sam <sam@FreeBSD.org>
Date: Thu, 31 Mar 2005 21:58:53 +0000
Subject: plug resource leak

Submitted by:	mdodd
Noticed by:	Coverity Prevent analysis tool
---
 sys/dev/mlx/mlx.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'sys/dev/mlx/mlx.c')

diff --git a/sys/dev/mlx/mlx.c b/sys/dev/mlx/mlx.c
index 844a265..dcee43c 100644
--- a/sys/dev/mlx/mlx.c
+++ b/sys/dev/mlx/mlx.c
@@ -1983,8 +1983,10 @@ mlx_user_command(struct mlx_softc *sc, struct mlx_usercommand *mu)
      * initial contents
      */
     if (mu->mu_datasize > 0) {
-	if (mu->mu_datasize > MAXPHYS)
-	    return (EINVAL);
+	if (mu->mu_datasize > MAXPHYS) {
+	    error = EINVAL;
+	    goto out;
+	}
 	if (((kbuf = malloc(mu->mu_datasize, M_DEVBUF, M_WAITOK)) == NULL) ||
 	    (error = copyin(mu->mu_buf, kbuf, mu->mu_datasize)))
 	    goto out;
-- 
cgit v1.1