From 9918d13b80941400bfab87834b1e2f1eea58c7c7 Mon Sep 17 00:00:00 2001 From: rwatson Date: Wed, 3 Aug 2005 00:18:35 +0000 Subject: Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week --- sys/dev/de/if_de.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'sys/dev/de/if_de.c') diff --git a/sys/dev/de/if_de.c b/sys/dev/de/if_de.c index 5fdff82..421d1aa 100644 --- a/sys/dev/de/if_de.c +++ b/sys/dev/de/if_de.c @@ -3026,6 +3026,7 @@ tulip_addr_filter( #endif multicnt = 0; + IF_ADDR_LOCK(sc->tulip_ifp); TAILQ_FOREACH(ifma, &sc->tulip_ifp->if_multiaddrs, ifma_link) { if (ifma->ifma_addr->sa_family == AF_LINK) @@ -3147,6 +3148,7 @@ tulip_addr_filter( #endif } } + IF_ADDR_UNLOCK(sc->tulip_ifp); #if defined(IFF_ALLMULTI) if (sc->tulip_flags & TULIP_ALLMULTI) sc->tulip_ifp->if_flags |= IFF_ALLMULTI; -- cgit v1.1