From bd1ed65f0faa90d56aad3c8fc1b55d874d1548d9 Mon Sep 17 00:00:00 2001
From: hselasky <hselasky@FreeBSD.org>
Date: Fri, 27 Jun 2014 16:33:43 +0000
Subject: Extend the meaning of the CTLFLAG_TUN flag to automatically check if
there is an environment variable which shall initialize the SYSCTL during
early boot. This works for all SYSCTL types both statically and dynamically
created ones, except for the SYSCTL NODE type and SYSCTLs which belong to
VNETs. A new flag, CTLFLAG_NOFETCH, has been added to be used in the case a
tunable sysctl has a custom initialisation function allowing the sysctl to
still be marked as a tunable. The kernel SYSCTL API is mostly the same, with
a few exceptions for some special operations like iterating childrens of a
static/extern SYSCTL node. This operation should probably be made into a
factored out common macro, hence some device drivers use this. The reason for
changing the SYSCTL API was the need for a SYSCTL parent OID pointer and not
only the SYSCTL parent OID list pointer in order to quickly generate the
sysctl path. The motivation behind this patch is to avoid parameter loading
cludges inside the OFED driver subsystem. Instead of adding special code to
the OFED driver subsystem to post-load tunables into dynamically created
sysctls, we generalize this in the kernel.
Other changes:
- Corrected a possibly incorrect sysctl name from "hw.cbb.intr_mask"
to "hw.pcic.intr_mask".
- Removed redundant TUNABLE statements throughout the kernel.
- Some minor code rewrites in connection to removing not needed
TUNABLE statements.
- Added a missing SYSCTL_DECL().
- Wrapped two very long lines.
- Avoid malloc()/free() inside sysctl string handling, in case it is
called to initialize a sysctl from a tunable, hence malloc()/free() is
not ready when sysctls from the sysctl dataset are registered.
- Bumped FreeBSD version to indicate SYSCTL API change.
MFC after: 2 weeks
Sponsored by: Mellanox Technologies
---
sys/dev/ath/if_ath_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
(limited to 'sys/dev/ath/if_ath_debug.c')
diff --git a/sys/dev/ath/if_ath_debug.c b/sys/dev/ath/if_ath_debug.c
index e3c73f5..d21ad6f 100644
--- a/sys/dev/ath/if_ath_debug.c
+++ b/sys/dev/ath/if_ath_debug.c
@@ -92,9 +92,8 @@ __FBSDID("$FreeBSD$");
uint64_t ath_debug = 0;
SYSCTL_DECL(_hw_ath);
-SYSCTL_QUAD(_hw_ath, OID_AUTO, debug, CTLFLAG_RW, &ath_debug,
+SYSCTL_QUAD(_hw_ath, OID_AUTO, debug, CTLFLAG_RWTUN, &ath_debug,
0, "control debugging printfs");
-TUNABLE_QUAD("hw.ath.debug", &ath_debug);
void
ath_printrxbuf(struct ath_softc *sc, const struct ath_buf *bf,
--
cgit v1.1