From 9918d13b80941400bfab87834b1e2f1eea58c7c7 Mon Sep 17 00:00:00 2001 From: rwatson Date: Wed, 3 Aug 2005 00:18:35 +0000 Subject: Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week --- sys/dev/ath/if_ath.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'sys/dev/ath/if_ath.c') diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c index 009fe24..7e91f30 100644 --- a/sys/dev/ath/if_ath.c +++ b/sys/dev/ath/if_ath.c @@ -1662,6 +1662,7 @@ ath_mode_init(struct ath_softc *sc) /* calculate and install multicast filter */ if ((ifp->if_flags & IFF_ALLMULTI) == 0) { mfilt[0] = mfilt[1] = 0; + IF_ADDR_LOCK(ifp); TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) { caddr_t dl; @@ -1674,6 +1675,7 @@ ath_mode_init(struct ath_softc *sc) pos &= 0x3f; mfilt[pos / 32] |= (1 << (pos % 32)); } + IF_ADDR_UNLOCK(ifp); } else { mfilt[0] = mfilt[1] = ~0; } -- cgit v1.1