From faae1c0f2f76b907ebecec0a309573fcdeb15802 Mon Sep 17 00:00:00 2001 From: kib Date: Tue, 14 Oct 2008 07:59:23 +0000 Subject: Make robust futexes work on linux32/amd64. Use PTRIN to read user-mode pointers. Change types used in the structures definitions to properly-sized architecture-specific types. Submitted by: dchagin MFC after: 1 week --- sys/compat/linux/linux_futex.c | 6 +++--- sys/compat/linux/linux_futex.h | 12 ------------ 2 files changed, 3 insertions(+), 15 deletions(-) (limited to 'sys/compat') diff --git a/sys/compat/linux/linux_futex.c b/sys/compat/linux/linux_futex.c index 043962e..c279276 100644 --- a/sys/compat/linux/linux_futex.c +++ b/sys/compat/linux/linux_futex.c @@ -661,17 +661,17 @@ release_futexes(struct proc *p) if (head == NULL) return; - if (fetch_robust_entry(&entry, &head->list.next, &pi)) + if (fetch_robust_entry(&entry, PTRIN(&head->list.next), &pi)) return; if (copyin(&head->futex_offset, &futex_offset, sizeof(l_ulong))) return; - if (fetch_robust_entry(&pending, &head->pending_list, &pip)) + if (fetch_robust_entry(&pending, PTRIN(&head->pending_list), &pip)) return; while (entry != &head->list) { - rc = fetch_robust_entry(&next_entry, &entry->next, &next_pi); + rc = fetch_robust_entry(&next_entry, PTRIN(&entry->next), &next_pi); if (entry != pending) if (handle_futex_death((char *)entry + futex_offset, diff --git a/sys/compat/linux/linux_futex.h b/sys/compat/linux/linux_futex.h index 0f7a393..d658925 100644 --- a/sys/compat/linux/linux_futex.h +++ b/sys/compat/linux/linux_futex.h @@ -63,18 +63,6 @@ #define FUTEX_OP_CMP_GT 4 /* if (oldval > CMPARG) wake */ #define FUTEX_OP_CMP_GE 5 /* if (oldval >= CMPARG) wake */ -/* This is defined by Linux user-space */ - -struct linux_robust_list { - struct linux_robust_list *next; -}; - -struct linux_robust_list_head { - struct linux_robust_list list; - l_ulong futex_offset; - struct linux_robust_list *pending_list; -}; - #define FUTEX_WAITERS 0x80000000 #define FUTEX_OWNER_DIED 0x40000000 #define FUTEX_TID_MASK 0x3fffffff -- cgit v1.1