From 9ec2799bcc08f8703844be561ca32554c6808a29 Mon Sep 17 00:00:00 2001 From: phk Date: Sat, 14 Aug 2004 08:38:17 +0000 Subject: Add XXX comment about findcdev() misuse. --- sys/compat/linux/linux_stats.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'sys/compat/linux') diff --git a/sys/compat/linux/linux_stats.c b/sys/compat/linux/linux_stats.c index a9545fd..4a78554 100644 --- a/sys/compat/linux/linux_stats.c +++ b/sys/compat/linux/linux_stats.c @@ -364,6 +364,12 @@ linux_ustat(struct thread *td, struct linux_ustat_args *args) * struct cdev *. The struct cdev *that is used now may as well be a truncated * struct cdev *returned from previous syscalls. Just return a bzeroed * ustat in that case. + * + * XXX: findcdev() SHALL not be used this way. Somebody (TM) will + * have to find a better way. It may be that we should stick + * a dev_t into struct mount, and walk the mountlist for a + * perfect match and failing that try again looking for a + * minor-truncated match. */ dev = findcdev(makedev(args->dev >> 8, args->dev & 0xFF)); if (dev != NULL && vfinddev(dev, &vp)) { -- cgit v1.1