From 6231c89ca356ca59780afac8c23b8b9333851cfc Mon Sep 17 00:00:00 2001 From: rwatson Date: Fri, 14 Jun 2002 07:24:01 +0000 Subject: Add a comment about how we should use vn_open() here instead of directly invoking VOP_OPEN(). This would reduce code redundancy with the rest of the kernel, and also is required for MAC to work properly. --- sys/compat/linux/linux_misc.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'sys/compat/linux/linux_misc.c') diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index d3384c6..c081fc1 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -302,6 +302,10 @@ linux_uselib(struct thread *td, struct linux_uselib_args *args) if (error) goto cleanup; + /* + * XXX: This should use vn_open() so that it is properly authorized, + * and to reduce code redundancy all over the place here. + */ error = VOP_OPEN(vp, FREAD, td->td_ucred, td); if (error) goto cleanup; -- cgit v1.1