From 2c51319876e43279c95d2cdc537d65784b50252d Mon Sep 17 00:00:00 2001 From: mav Date: Sat, 29 Oct 2016 08:47:23 +0000 Subject: MFC r307507, r307509, r307515: Consider device as clean even if SYNCHRONIZE CACHE failed. If device reservation was preempted by other initiator, our sync request will always fail. Without this change CAM tried to sync cache on every following device close, including numerous GEOM tasting opens/closes, causing lots of useless noise in logs. --- sys/cam/ata/ata_da.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'sys/cam/ata') diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c index b59c649..808dc72 100644 --- a/sys/cam/ata/ata_da.c +++ b/sys/cam/ata/ata_da.c @@ -926,8 +926,7 @@ adaclose(struct disk *dp) if (error != 0) xpt_print(periph->path, "Synchronize cache failed\n"); - else - softc->flags &= ~ADA_FLAG_DIRTY; + softc->flags &= ~ADA_FLAG_DIRTY; xpt_release_ccb(ccb); cam_periph_unhold(periph); } -- cgit v1.1