From 9ad347c496791d44755a039c789c80c0d24da3cb Mon Sep 17 00:00:00 2001 From: loos Date: Tue, 18 Nov 2014 17:22:08 +0000 Subject: Moves all the duplicate code to a single function. Verify for invalid modes and unwanted flags before pass the new flags to driver. --- sys/arm/samsung/exynos/exynos5_pad.c | 9 --------- 1 file changed, 9 deletions(-) (limited to 'sys/arm/samsung') diff --git a/sys/arm/samsung/exynos/exynos5_pad.c b/sys/arm/samsung/exynos/exynos5_pad.c index d00eddc..c28ebb1 100644 --- a/sys/arm/samsung/exynos/exynos5_pad.c +++ b/sys/arm/samsung/exynos/exynos5_pad.c @@ -764,15 +764,6 @@ pad_pin_setflags(device_t dev, uint32_t pin, uint32_t flags) if (i >= sc->gpio_npins) return (EINVAL); - /* Check for unwanted flags. */ - if ((flags & sc->gpio_pins[i].gp_caps) != flags) - return (EINVAL); - - /* Can't mix input/output together */ - if ((flags & (GPIO_PIN_INPUT|GPIO_PIN_OUTPUT)) == - (GPIO_PIN_INPUT|GPIO_PIN_OUTPUT)) - return (EINVAL); - pad_pin_configure(sc, &sc->gpio_pins[i], flags); return (0); -- cgit v1.1