From 17e14c6132be998c8e8d0c2fc89ff0b66d24999c Mon Sep 17 00:00:00 2001 From: marius Date: Tue, 22 Nov 2011 21:28:20 +0000 Subject: - There's no need to overwrite the default device method with the default one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. --- sys/arm/econa/ehci_ebus.c | 5 +---- sys/arm/econa/ohci_ec.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) (limited to 'sys/arm/econa') diff --git a/sys/arm/econa/ehci_ebus.c b/sys/arm/econa/ehci_ebus.c index 8d5bed2..8403da9 100644 --- a/sys/arm/econa/ehci_ebus.c +++ b/sys/arm/econa/ehci_ebus.c @@ -281,10 +281,7 @@ static device_method_t ehci_methods[] = { DEVMETHOD(device_resume, ehci_ebus_resume), DEVMETHOD(device_shutdown, ehci_ebus_shutdown), - /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - - {0, 0} + DEVMETHOD_END }; static driver_t ehci_driver = { diff --git a/sys/arm/econa/ohci_ec.c b/sys/arm/econa/ohci_ec.c index 6b25580..5d103a3 100644 --- a/sys/arm/econa/ohci_ec.c +++ b/sys/arm/econa/ohci_ec.c @@ -222,10 +222,7 @@ static device_method_t ohci_methods[] = { DEVMETHOD(device_detach, ohci_ec_detach), DEVMETHOD(device_shutdown, bus_generic_shutdown), - /* Bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - - {0, 0} + DEVMETHOD_END }; static driver_t ohci_driver = { -- cgit v1.1