From ffad260b82d9dabbc67fddb3f45c866ed54a4542 Mon Sep 17 00:00:00 2001 From: mckusick Date: Thu, 22 May 2008 22:19:33 +0000 Subject: This fixes the "getfile: lost data" panic when restoring dumps on a 7.0 or later system that were created on a pre-5.0 system. We must ensure that restore zeros out the previously undefined birthtime and external attribute size fields when reading dump tapes made by the UFS1 dump program. The problem is that UFS2 dump carefully zeros out the unused birthtime and external attribute size fields in the dump header when dumping UFS1 filesystems, but the UFS1 dump didn't know about those fields (they were spares) so just left whatever random junk was in them. So, when restoring one of these pre-UFS2 dumps, the new restore would eventually trip across a header that had a non-zero external attribute size and try to extract it. That consumed several tape blocks which left it totally out of sync and very unhappy (i.e., the panic). The fix is in the gethead() function which modernizes old headers by copying old fields to their new location (and with this fix) zeroing out previously undefined fields. PR: bin/120881 Review by: David Malone & Scott Lambert MFC after: 1 week --- sbin/restore/tape.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'sbin/restore') diff --git a/sbin/restore/tape.c b/sbin/restore/tape.c index 1386995..debed5f 100644 --- a/sbin/restore/tape.c +++ b/sbin/restore/tape.c @@ -1424,6 +1424,9 @@ gethead(struct s_spcl *buf) buf->c_ddate = _time32_to_time(buf->c_old_ddate); buf->c_atime = _time32_to_time(buf->c_old_atime); buf->c_mtime = _time32_to_time(buf->c_old_mtime); + buf->c_birthtime = 0; + buf->c_birthtimensec = 0; + buf->c_extsize = 0; } break; -- cgit v1.1