From a4107fca32bc1c4b153c0940afcc26f8c6b6b742 Mon Sep 17 00:00:00 2001 From: jkh Date: Sun, 3 Mar 1996 08:44:22 +0000 Subject: Close PR#17. This may be a contraversal fix in that now mount will spit out two error lines for a bogus filesystem type, e.g: root@time-> mount -t foo /dev/sd0a /mnt mount: exec /sbin/mount_foo for /mnt: No such file or directory mount: exec /usr/sbin/mount_foo for /mnt: No such file or directory But I would submit that if you're even going to scan multiple directories for a mount_foo (which I actually think is somewhat bogus - if it's not in /sbin, you're probably in big trouble anyway), you should emit an error for each one. I got multiple complaints (in addition to the PR) that the existing behavior was very confusing. --- sbin/mount_ifs/mount.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'sbin/mount_ifs') diff --git a/sbin/mount_ifs/mount.c b/sbin/mount_ifs/mount.c index cf05d3f..1be00ec 100644 --- a/sbin/mount_ifs/mount.c +++ b/sbin/mount_ifs/mount.c @@ -332,12 +332,8 @@ mountfs(vfstype, spec, name, flags, options, mntopts) (void)snprintf(execname, sizeof(execname), "%s/mount_%s", *edir, vfstype); execv(execname, (char * const *)argv); - if (errno != ENOENT) - warn("exec %s for %s", execname, name); - } while (*++edir != NULL); - - if (errno == ENOENT) warn("exec %s for %s", execname, name); + } while (*++edir != NULL); exit(1); /* NOTREACHED */ default: /* Parent. */ -- cgit v1.1