From 240f0e9a46a69e86979ea5300fa84b96a1e0f96d Mon Sep 17 00:00:00 2001
From: melifaro <melifaro@FreeBSD.org>
Date: Sun, 19 Apr 2015 12:49:30 +0000
Subject: Fix use-after-free.

Reported by:	Coverity Scan, pfg
CID:		1245747
---
 sbin/ipfw/nat.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'sbin/ipfw')

diff --git a/sbin/ipfw/nat.c b/sbin/ipfw/nat.c
index 4391778..184b172 100644
--- a/sbin/ipfw/nat.c
+++ b/sbin/ipfw/nat.c
@@ -1008,11 +1008,10 @@ nat_foreach(nat_cb_t *f, void *arg, int sort)
 
 		olh->size = sz;
 		if (do_get3(IP_FW_NAT44_LIST_NAT, &olh->opheader, &sz) != 0) {
+			sz = olh->size;
 			free(olh);
-			if (errno == ENOMEM) {
-				sz = olh->size;
+			if (errno == ENOMEM)
 				continue;
-			}
 			return (errno);
 		}
 
-- 
cgit v1.1