From 71859c694bcd981fe39ce9fb5485e60ebafff7a9 Mon Sep 17 00:00:00 2001 From: nate Date: Thu, 9 May 1996 16:38:27 +0000 Subject: From: Terry Lambert Subject: Fix for annoying fsck bug Date: Wed, 24 Jan 1996 13:33:29 -0700 (MST) The following small diff fixes the annoying fsck bug that causes it to need to be run twice to end up with correct reference counts for inodes for directories that had subdirectories relocated into the lost+found directory. I found the need to rerun *extremely* annoying. This fix causes the count to be correctly adjusted later in pass 4 by correctly stating the parent reference count. Note that the parent reference count is incremented when the directory entry is made (for ".."), but is not really there in the case of a directory that does not make an entry in its parent dir. This can be tested by waiting for the inode sync after cd'ing from a shell into a test fs. Then you "mkdir xxx yyy zzz", wait a second, and hit the machine reset button. Reviewed by: nate (Tested lots of crashes :) Submitted by: Terry Lambert --- sbin/fsck_ffs/dir.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'sbin/fsck_ffs/dir.c') diff --git a/sbin/fsck_ffs/dir.c b/sbin/fsck_ffs/dir.c index 888bad2..9a2b923 100644 --- a/sbin/fsck_ffs/dir.c +++ b/sbin/fsck_ffs/dir.c @@ -472,8 +472,18 @@ linkup(orphan, parentdir) inodirty(); lncntp[lfdir]++; pwarn("DIR I=%lu CONNECTED. ", orphan); - if (parentdir != (ino_t)-1) + if (parentdir != (ino_t)-1) { printf("PARENT WAS I=%lu\n", parentdir); + /* + * The parent directory, because of the ordering + * guarantees, has had the link count incremented + * for the child, but no entry was made. This + * fixes the parent link count so that fsck does + * not need to be rerun. + */ + lncntp[parentdir]++; + + } if (preen == 0) printf("\n"); } -- cgit v1.1