From f0e9277351d131ebcb8cf08cb5acffe41a1ac16a Mon Sep 17 00:00:00 2001 From: cperciva Date: Mon, 21 May 2007 04:45:24 +0000 Subject: Don't test for NULL when it is both unnecessary (the pointer is checked against NULL when it is first allocated) and pointless (we've already dereferenced the pointer several times). Found by: Coverity Prevent(tm) CID: 3204 --- lib/libarchive/archive_read_support_format_tar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/libarchive/archive_read_support_format_tar.c b/lib/libarchive/archive_read_support_format_tar.c index 3f52cab..d778b9d 100644 --- a/lib/libarchive/archive_read_support_format_tar.c +++ b/lib/libarchive/archive_read_support_format_tar.c @@ -1168,7 +1168,7 @@ pax_header(struct archive_read *a, struct tar *tar, struct archive_entry *entry, return (-1); while (*wp && *wp != L'=') ++wp; - if (*wp == L'\0' || wp == NULL) { + if (*wp == L'\0') { archive_set_error(&a->archive, ARCHIVE_ERRNO_MISC, "Invalid pax extended attributes"); return (ARCHIVE_WARN); -- cgit v1.1