From 9ead8ff0881eb8c37191380bb7ea2d0763596ae5 Mon Sep 17 00:00:00 2001 From: ache Date: Tue, 22 Jul 2008 17:10:18 +0000 Subject: Fixes based on bde's feedback. 1) Unindent and sort variables. 2) Indent struct members. 3) Remove _packed, use guaranteed >128 bytes size and only first 128 bytes from the structure. 4) Reword comment. Obtained from: bde --- lib/libc/gen/arc4random.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'lib/libc') diff --git a/lib/libc/gen/arc4random.c b/lib/libc/gen/arc4random.c index 6f2dbde..84f70c9 100644 --- a/lib/libc/gen/arc4random.c +++ b/lib/libc/gen/arc4random.c @@ -55,6 +55,7 @@ struct arc4_stream { static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER; #define RANDOMDEV "/dev/random" +#define KEYSIZE 128 #define THREAD_LOCK() \ do { \ if (__isthreaded) \ @@ -106,28 +107,27 @@ arc4_addrandom(u_char *dat, int datlen) static void arc4_stir(void) { - int fd, n, done; + int done, fd, n; struct { - struct timeval tv; - pid_t pid; - u_int8_t rnd[128 - sizeof(struct timeval) - sizeof(pid_t)]; - } __packed rdat; + struct timeval tv; + pid_t pid; + u_int8_t rnd[KEYSIZE]; + } rdat; fd = _open(RANDOMDEV, O_RDONLY, 0); done = 0; if (fd >= 0) { - if (_read(fd, &rdat, sizeof(rdat)) == sizeof(rdat)) + if (_read(fd, &rdat, KEYSIZE) == KEYSIZE) done = 1; (void)_close(fd); } - /* !done? Ah, what the heck. We'll just take whatever was on the - * stack... */ if (!done) { (void)gettimeofday(&rdat.tv, NULL); rdat.pid = getpid(); + /* We'll just take whatever was on the stack too... */ } - arc4_addrandom((u_char *)&rdat, sizeof(rdat)); + arc4_addrandom((u_char *)&rdat, KEYSIZE); /* * Throw away the first N bytes of output, as suggested in the -- cgit v1.1