From 036f5d34b6bc40bdd6c38d8ba34d475e47a6f288 Mon Sep 17 00:00:00 2001 From: jilles Date: Sun, 13 Sep 2015 14:00:49 +0000 Subject: setuid(2): Suggest O_CLOEXEC instead of fcntl(F_SETFD). --- lib/libc/sys/setuid.2 | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'lib/libc') diff --git a/lib/libc/sys/setuid.2 b/lib/libc/sys/setuid.2 index 4c7d5ad..54d89bc 100644 --- a/lib/libc/sys/setuid.2 +++ b/lib/libc/sys/setuid.2 @@ -28,7 +28,7 @@ .\" @(#)setuid.2 8.1 (Berkeley) 6/4/93 .\" $FreeBSD$ .\" -.Dd June 4, 1993 +.Dd September 13, 2015 .Dt SETUID 2 .Os .Sh NAME @@ -178,15 +178,10 @@ pseudocode(void) int fd; /* ... */ - fd = open("/path/to/sensitive/data", O_RDWR); + fd = open("/path/to/sensitive/data", O_RDWR | O_CLOEXEC); if (fd == -1) err(1, "open"); - /* - * Set close-on-exec flag; see fcntl(2) for more information. - */ - if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1) - err(1, "fcntl(F_SETFD)"); /* ... */ execve(path, argv, environ); } -- cgit v1.1