From 307713b0cf837122c02128382f81fbe757863cb1 Mon Sep 17 00:00:00 2001 From: trasz Date: Thu, 3 Jun 2010 14:29:17 +0000 Subject: _posix1e_acl_sort() never returns anything other than 0; change its return type to void and update callers. This simplifies code and fixes one place where the returned value was not actually checked. Found with: Coverity Prevent CID: 4791 --- lib/libc/posix1e/acl_support.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/libc/posix1e/acl_support.h') diff --git a/lib/libc/posix1e/acl_support.h b/lib/libc/posix1e/acl_support.h index 9826577..8f7dfed 100644 --- a/lib/libc/posix1e/acl_support.h +++ b/lib/libc/posix1e/acl_support.h @@ -50,7 +50,7 @@ int _nfs4_format_access_mask(char *str, size_t size, acl_perm_t var, int verbose int _nfs4_parse_flags(const char *str, acl_flag_t *var); int _nfs4_parse_access_mask(const char *str, acl_perm_t *var); int _posix1e_acl_check(acl_t acl); -int _posix1e_acl_sort(acl_t acl); +void _posix1e_acl_sort(acl_t acl); int _posix1e_acl(acl_t acl, acl_type_t type); int _posix1e_acl_id_to_name(acl_tag_t tag, uid_t id, ssize_t buf_len, char *buf, int flags); -- cgit v1.1 From 01650ad878472e2c42f627f44fca98f5a039d9fa Mon Sep 17 00:00:00 2001 From: trasz Date: Tue, 6 Jul 2010 17:20:08 +0000 Subject: Fix acl_from_text(3) - and, therefore, setfacl(1) - for user and group names names starting with a digit. MFC after: 1 month --- lib/libc/posix1e/acl_support.h | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/libc/posix1e/acl_support.h') diff --git a/lib/libc/posix1e/acl_support.h b/lib/libc/posix1e/acl_support.h index 8f7dfed..11fa29b 100644 --- a/lib/libc/posix1e/acl_support.h +++ b/lib/libc/posix1e/acl_support.h @@ -61,5 +61,6 @@ int _posix1e_acl_add_entry(acl_t acl, acl_tag_t tag, uid_t id, acl_perm_t perm); char *string_skip_whitespace(char *string); void string_trim_trailing_whitespace(char *string); +int _acl_name_to_id(acl_tag_t tag, char *name, uid_t *id); #endif -- cgit v1.1