From 791c39f548db6fb2fb0c90923d3e40831d869955 Mon Sep 17 00:00:00 2001 From: robert Date: Wed, 19 Mar 2003 14:01:35 +0000 Subject: If realloc(3) fails in copyline(), do not make matters worse by leaving without deallocating `data' thereby creating a memory leak. --- lib/libc/gen/getgrent.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) (limited to 'lib/libc/gen') diff --git a/lib/libc/gen/getgrent.c b/lib/libc/gen/getgrent.c index ec423a4..a073946 100644 --- a/lib/libc/gen/getgrent.c +++ b/lib/libc/gen/getgrent.c @@ -293,9 +293,12 @@ _dns_grscan(rv, cb_data, ap) } /* only check first elem */ - if (copyline(hp[0]) == 0) - return NS_UNAVAIL; + r = copyline(hp[0]); hesiod_free_list(context, hp); + if (r == 0) { + r = NS_UNAVAIL; + break; + } if (matchline(search, gid, name)) { r = NS_SUCCESS; break; @@ -360,9 +363,10 @@ _nis_grscan(rv, cb_data, ap) return NS_UNAVAIL; } data[datalen] = '\0'; /* clear trailing \n */ - if (copyline(data) == 0) - return NS_UNAVAIL; + r = copyline(data); free(data); + if (r == 0) + return NS_UNAVAIL; if (matchline(search, gid, name)) return NS_SUCCESS; else @@ -410,9 +414,10 @@ _nis_grscan(rv, cb_data, ap) } } data[datalen] = '\0'; /* clear trailing \n */ - if (copyline(data) == 0) - return NS_UNAVAIL; + r = copyline(data); free(data); + if (r == 0) + return NS_UNAVAIL; if (matchline(search, gid, name)) return NS_SUCCESS; } -- cgit v1.1