From 126d9ed0637984e41d484059dd63e0cf4c2077d6 Mon Sep 17 00:00:00 2001 From: ed Date: Sun, 24 Aug 2008 10:01:22 +0000 Subject: Remove the now unneeded pt_chown utility. Before we had a posix_openpt() that allocated PTY's with proper permissions in place, we used this set-uid utility to change the ownership of PTY slave devices to the real user ID of the process. This utility was used to implement grantpt(). In my first designs of the MPSAFE TTY layer, I replaced this by adding an ioctl() called TIOCGRANTPT, which was used to change the ownership. I left the pt_chown utility, because older C libraries needed it to work properly. After some discussions back in June I changed the PTY code to set permissions properly upon creation. Fortunately the previous grantpt() implementation changed permissions by hand when pt_chown is not installed, which always succeeds. This means grantpt() still works properly, even though the set-uid utility is missing. I've done tests with FreeBSD 5.2.1, FreeBSD 6.3 and FreeBSD 7.0 jails. All of them still work if I remove pt_chown. Reviewed by: philip (ex-mentor) --- ObsoleteFiles.inc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ObsoleteFiles.inc') diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index 60f3c53..6452a04 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -14,6 +14,8 @@ # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last. # +# 20080823: removal of unneeded pt_chown, to implement grantpt(3) +OLD_FILES+=usr/libexec/pt_chown # 20080820: MPSAFE TTY layer integrated OLD_FILES+=usr/include/sys/linedisc.h OLD_FILES+=usr/share/man/man3/posix_openpt.3.gz -- cgit v1.1