From a5110e6b7d74319cc9d4c83b44279e027a9056ca Mon Sep 17 00:00:00 2001 From: oleg Date: Mon, 8 Sep 2008 18:10:15 +0000 Subject: bge_tick(): do not touch PHY if link is up. This should solve problem with extra input errors for some BCM57XX chips. PR: kern/122295 --- sys/dev/bge/if_bge.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/dev/bge/if_bge.c b/sys/dev/bge/if_bge.c index 3735088..d8086bf 100644 --- a/sys/dev/bge/if_bge.c +++ b/sys/dev/bge/if_bge.c @@ -3387,8 +3387,12 @@ bge_tick(void *xsc) if ((sc->bge_flags & BGE_FLAG_TBI) == 0) { mii = device_get_softc(sc->bge_miibus); - /* Don't mess with the PHY in IPMI/ASF mode */ - if (!((sc->bge_asf_mode & ASF_STACKUP) && (sc->bge_link))) + /* + * Do not touch PHY if we have link up. This could break + * IPMI/ASF mode or produce extra input errors + * (extra errors was reported for bcm5701 & bcm5704). + */ + if (!sc->bge_link) mii_tick(mii); } else { /* -- cgit v1.1