From 266c009204d30c278c73ab3c0c80de525ca9cbfb Mon Sep 17 00:00:00 2001 From: adrian Date: Fri, 5 Jul 2013 00:03:53 +0000 Subject: Document the current 11n rate selection shortcoming in the AMRR code. --- sys/net80211/ieee80211_amrr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/net80211/ieee80211_amrr.c b/sys/net80211/ieee80211_amrr.c index 874659f..003b4bc 100644 --- a/sys/net80211/ieee80211_amrr.c +++ b/sys/net80211/ieee80211_amrr.c @@ -240,6 +240,14 @@ amrr_update(struct ieee80211_amrr *amrr, struct ieee80211_amrr_node *amn, amn->amn_txcnt, amn->amn_retrycnt); + /* + * XXX This is totally bogus for 11n, as although high MCS + * rates for each stream may be failing, the next stream + * should be checked. + * + * Eg, if MCS5 is ok but MCS6/7 isn't, and we can go up to + * MCS23, we should skip 6/7 and try 8 onwards. + */ if (is_success(amn)) { amn->amn_success++; if (amn->amn_success >= amn->amn_success_threshold && -- cgit v1.1