summaryrefslogtreecommitdiffstats
path: root/usr.sbin
Commit message (Collapse)AuthorAgeFilesLines
* makefs: Provide a -T option to set timestamps to a consistent valueemaste2016-06-148-54/+129
| | | | | | | | | | | | This is taken from the NetBSD versions listed below and adapted to the makefs version in FreeBSD, along with a bug fix from cem@ that will be sent to NetBSD. Reviewed by: pfg Approved by: re (gjb) Obtained from: NetBSD MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D6835
* Fix usr.sbin/extattr testcases on tmpfsasomers2016-06-131-0/+27
| | | | | | | | | | | | | Skip the usr.sbin/extattr testscases if $TMPDIR is tmpfs, which doesn't support extended attributes PR: 210184 Reported by: ngie Reviewed by: ngie Approved by: re (glebius) MFC after: 4 weeks Differential Revision: https://reviews.freebsd.org/D6802 Sponsored by: Spectra Logic Corp
* Add missing break in lock_partialfilelock(..) with NFS_RESERRngie2016-06-131-0/+1
| | | | | | | | | | | | | | This will help ensure that the right error is trickled up when the function is called if the lock status is NFS_RESERR Differential Revision: https://reviews.freebsd.org/D6622 Reviewed by: rmacklem Approved by: re (gjb) Tested with: fsx; svn info/svnversion (uses bdb locking); locktests from Bull http://nfsv4.bullopensource.org/tools/tests/locktest.php MFC after: 2 weeks Reported by: Coverity CID: 1008161, 1304956 Sponsored by: EMC / Isilon Storage Division
* Change my given name from "Garrett" to "Ngie"ngie2016-06-131-1/+1
| | | | | | | A legal name change from "Garrett" to "Ngie", as well as a FreeBSD account name change, is pending. Approved by: re (hrs)
* Fix a miss merge in the services_mkdb(8) man pageallanjude2016-06-101-1/+1
| | | | | | | Restore the cross reference to getservent(3) to the correct line Approved by: re (gjb) Sponsored by: BSDCan Hacker Lounge
* Fix bsdinstall for root-on-zfs with MBR partitioningallanjude2016-06-101-9/+5
| | | | | | | | | | | | Fix an error where vfs.root.mountfrom was not always set as required when creating a bootpool. After the recent geliboot changes, it was only set if the main pool was encrypted. Also resolve an error where the bootpool was unmounted twice causing bsdinstall to stop with an error message about the failed command. Approved by: re (gjb) Sponsored by: BSDCan Hacker Lounge
* rpcbind(8): Make use of some xdr_* macros.pfg2016-06-091-3/+3
| | | | | | xdr_rpcproc, xdr_rpcprog and xdr_rpcvers were broken in older versions of FreeBSD but fixed in r296394. Give them some use hoping they help make the code somewhat more readable.
* Decouple MaxBurstLength and FirstBurstLength from MaxRecvDataSegmentLengthtrasz2016-06-092-10/+18
| | | | | | | reported by the ICL module in iscsid(8). This harmed performance and was just wrong. MFC after: 1 month
* Don't cap FirstBurstLength to maximum MaxRecvDataSegmentLength claimedtrasz2016-06-092-6/+6
| | | | | | | by the offload driver; there is no reason to do so, and it actually harms performance. MFC after: 1 month
* Fix spelling of the casper introduced in the r296047.oshogbo2016-06-081-1/+1
| | | | | PR: 210031 Reported by: AllanJude, jmallett
* bsdinstall: add country/regulatory domain configuration dialog.avos2016-06-081-32/+183
| | | | | | | | | Allow to setup country and/or regulatory domain before scanning (since channel list is affected by regulatory restrictions this may impact scan results). PR: 182600 (originally) Differential Revision: https://reviews.freebsd.org/D6325
* Bounds check rpcbs_rmtcall(..) to ensure rtype is less than RPCBVERS_STATngie2016-06-081-1/+1
| | | | | | | | | | | | | | | | Not returning if rtype == RPCBVERS_STAT will cause us to overrun the inf array, as it's defined to be exactly RPCBVERS_STAT elements in rpcb_prot.x: > include/rpc/rpcb_prot.x:typedef rpcb_stat rpcb_stat_byvers[RPCBVERS_STAT]; The proposed change also matches the rest of the rtype upper bound checks in the file, so the original change was likely a typo. MFC after: 2 weeks Reported by: Coverity CID: 1007567 Reviewed by: truckman Sponsored by: EMC / Isilon Storage Division
* Separate BLACKLIST vs BLACKLIST_SUPPORT properlylidl2016-06-071-3/+3
| | | | Sponsored by: The FreeBSD Foundation
* Bump date in both manpages.araujo2016-06-071-1/+1
| | | | Reported by: rodrigc
* [ath3k] add a replacement ath3k firmware loading tool.adrian2016-06-079-307/+1052
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is influenced by the ath3k driver from linux (circa 2013, this is how long I've been sitting on this.) It handles loading in firmware using the newer model, where it assembles the right set of firmware blobs and board configuration based on the device list and querying the device. The older utility could only load in a single image - which sometimes was ath3k-1.fw and sometimes was ath3k-2.fw. However, the ath3k maintainers didn't want to keep adding in binaries that were just derivatives with a separate board config, so they deleted ath3k-2.fw from the Linux firmware repository and instead, well, did this. Now, this has been tested against AR3011 and AR3012 NICs from the AR9285+BT combo up through to the QCA9565+BT combo. It doesn't yet work with the QCAFN222 NIC as that is some newer chip. The firmware can be grabbed from https://github.com/erikarn/ath3kfw/ in the share/firmware/ath3k directory. I'll update this utility over time to support the newer firmware drops (newer than mid-2013) which should pull in the QCNFA222 and subsequent chips. Tested: * AR9285 + BT * AR9287 + BT * AR9485 + BT * AR9462 + BT * QCA9565 + BT
* Add an entry on rc.conf(5) explaining the new optionsaraujo2016-06-071-1/+3
| | | | | | | | | | nis_ypldap_enable and nis_ypldap_flags. Also add an entry on ypldap(8) that it is a feature ready and appears on FreeBSD 11.0. Requested by: rodrigc Relnotes: Yes
* newsyslog: Eliminate unnecessary sleep(10) when -R and -s are specifiedvangyzen2016-06-061-7/+9
| | | | | | | | | | | | | | | | | | After going through the signal work list, during which do_sigwork() is called and essentially does nothing because -s and -R were specified on the command line, newsyslog will sleep for 10 seconds as the (verbose) code says: "Pause 10 seconds to allow daemon(s) to close log file(s)". However, the man page verbiage for -R (and -s) seems quite clear that this sleep() is unnecessary because the daemon was expected to have already closed the log file before calling newsyslog. PR: 210020 Submitted by: David A. Bright <david_a_bright@dell.com> MFC after: 1 week Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D6727
* For pointers use NULL instead of 0.araujo2016-06-061-1/+1
|
* Remove duplicated semicolons.trasz2016-06-051-4/+4
| | | | MFC after: 1 month
* Report negotiated MaxBurstLength and FirstBurstLength in "iscsictl -v"trasz2016-06-054-4/+13
| | | | | | and "ctladm islist -v" outputs. MFC after: 1 month
* Fix typo preventing pw {user,group}next -C from working as expectedbapt2016-06-042-2/+2
| | | | | Reported by: Mike Selnet via forums.freebsd.org MFC after: 3 days
* WITH_META_MODE: Don't expect meta files for side-effect generated files.bdrewery2016-06-032-0/+4
| | | | | | | | | The first file in these lists will generate everything else so only it should be getting a .meta file. With bmake's missing=yes meta feature these would otherwise cause a rebuild without the .NOMETA hint. Sponsored by: EMC / Isilon Storage Division
* DIRDEPS_BUILD: Connect new directories and update dependencies.bdrewery2016-06-033-0/+65
| | | | Sponsored by: EMC / Isilon Storage Division
* MFV r301238:delphij2016-06-039-20/+42
| | | | | | | | | ntp 4.2.8p8. Security: CVE-2016-4957, CVE-2016-4953, CVE-2016-4954 Security: CVE-2016-4955, CVE-2016-4956 Security: FreeBSD-SA-16:24.ntp With hat: so
* Add blacklistd.conf manpagelidl2016-06-031-1/+1
| | | | | | | | | | Install the blacklistd.conf man page, missed in the original commit. Submitted by: Herbert J. Skuhra ( herbert at mailbox.org ) Reviewed by: rpaulo Approved by: rpaulo Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D6702
* Add basic blacklist build supportlidl2016-06-023-0/+48
| | | | | | | | Reviewed by: rpaulo Approved by: rpaulo Relnotes: YES Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D5913
* Revert r301137 and r301163, and implement a correct fixgjb2016-06-012-0/+40
| | | | | | | | | | for the CONFS issue with dma.conf and ppp.conf. Thank you very much to Bryan Drewery for looking into the problem and providing this fix. Pointyhat: gjb Sponsored by: The FreeBSD Foundation
* Revert r289096:gjb2016-06-012-40/+0
| | | | | | | | | | | | | Files listed in 'CONFS' are not properly included in new installations (missing from base.txz), for reasons I still do not fully understand. This reverts the change excluding /etc/ppp/ppp.conf from a new installation. /etc/dma/dma.conf is also affected, but requires a different solution, still being investigated. Reported by: Ben Woods Sponsored by: The FreeBSD Foundation
* Fix tzsetup not installing /etc/localtime for UTCsmh2016-06-011-2/+3
| | | | | | | | | | | | | | | | | | | If tzsetup UTC is run then it successfully configured the system for UTC including installing /etc/localtime however if the user ran just tzsetup for interactive configuration and select UTC no /etc/localtime was installed which resulted in failures for utilities which require said file. Change set_zone_utc to call install_zoneinfo("UTC") to ensure that /etc/localtime is created for interactive UTC selection. Users who have previously run tzsetup in interactive mode and select UTC can install the missing /etc/localtime by running tzsetup -r. Also correct static miss-match for set_zone_utc. MFC after: 2 weeks Relnotes: Yes Sponsored by: Multiplay
* Describe default value for "offload".trasz2016-06-011-0/+2
| | | | MFC after: 1 month
* keyserv(1): drop useless comparison.pfg2016-05-301-4/+5
| | | | | | | | | | | Comparing a character array against NULL serves no purpose. In any case we are always asigning a value just before using the value so obviate the comparison altogether. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D6651 CID: 1008422
* Follow up to r300932ngie2016-05-291-1/+2
| | | | | | | | | | | | | | | In the event MK_INET6 != no in userspace, but is disabled in the kernel, or if there aren't any IPv6 addresses configured in userspace (for lo0 and all physical interfaces), rpcbind would terminate immediately instead of silently failing on Skip over the IPv6 block to its respective cleanup with freeifaddrs if creating the socket failed instead of terminating rpcbind immediately MFC after: 6 days X-MFC with: r300932 Reported by: O. Hartmann <ohartman@zedat.fu-berlin.de> Sponsored by: EMC / Isilon Storage Division
* Fix rpcbind init after r300941.markj2016-05-291-1/+2
| | | | | | | | | | - getaddrinfo() sets res = NULL on failure and freeaddrinfo() always dereferences its argument, so we should only free the address list after a successful call. - Address a second potential leak caused by getaddrinfo(AF_INET6) overwriting the address list returned by getaddrinfo(AF_INET). X-MFC-With: r300941
* Invoke the dirname() function in a POSIX compliant way.ed2016-05-291-2/+3
| | | | | | | | | | | | | POSIX requires that the argument of dirname() is of type "char *". In other words, the input buffer can be modified by the function to store the directory name. Pull a copy of the string before calling dirname(). We don't care about freeing up the memory afterwards, as this is done at the very bottom of main(), right before the program terminates. Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D6628
* Staticize variables only used in rpcbind.cngie2016-05-291-7/+7
| | | | | | | This is some low hanging fruit necessary for making this WARNS?= 6 clean MFC after: 3 days Sponsored by: EMC / Isilon Storage Division
* Remove unnecessary caller_uaddr != NULL test before calling free on itngie2016-05-291-2/+1
| | | | | MFC after: 3 days Sponsored by: EMC / Isilon Storage Division
* Remove a useless if (x != NULL) check before calling free on allocated_uaddrngie2016-05-291-2/+1
| | | | | MFC after: 3 days Sponsored by: EMC / Isilon Storage Division
* Don't leak res in network_init(..)ngie2016-05-291-0/+1
| | | | | | | | | Call freeaddrinfo on it after it's been used MFC after: 1 week Reported by: Coverity CID: 1225050 Sponsored by: EMC / Isilon Storage Division
* Mark out_of_mem(..) and usage(..) with __dead2 as they both directly call exitngie2016-05-291-4/+4
| | | | | | | as a hint to static analysis tools MFC after: 1 week Sponsored by: EMC / Isilon Storage Division
* Plug leak with ifp by calling freeifaddrs after calling getifaddrsngie2016-05-291-0/+1
| | | | | | MFC after: 1 week Obtained from: NetBSD v1.18 Sponsored by: EMC / Isilon Storage Division
* Catch malloc(3) errors and socket(2) errorsngie2016-05-291-0/+7
| | | | | | | | | | | - malloc failing will result in a delayed segfault - socket failing will result in delayed failures with setsockopt Exit in the event that either of these high-level conditions are met. Reported by: Coverity CID: 976288, 976321, 976858 Sponsored by: EMC / Isilon Storage Division
* Only expose `hint_uaddr` in the ND_DEBUG casengie2016-05-271-0/+6
| | | | | | | | This fixes a -Wunused-but-set-variable warning with gcc MFC after: 1 week Reported by: gcc 5 Sponsored by: EMC / Isilon Storage Division
* Improve error message when failing to open a backing filebapt2016-05-271-2/+3
| | | | | | | | | | | | | | When bhyve cannot open a backing file, it now says explicitly which file could not be opened Note that the change has only be maed in block_if.c and not in pci_virtio_block.c as the error will always be catched by the first PR: 202321 (different patch) Reviewed by: grehan MFC after: 3 day Sponsored by: Gandi.net Differential Revision: https://reviews.freebsd.org/D6576
* WITH_AUTO_OBJ: Fix crunchgen builds.bdrewery2016-05-261-1/+6
| | | | | | | | | | | | | | | | | Passing MAKEOBJDIRPREFIX to the main prog build (rescue) would confuse WITH_AUTO_OBJ and cause it to create a recursed object directory that then broke the actual prog build. This is normally not a problem since we do not call 'make -f prog.mk obj' before building anything in it. Crunchgen(1) also assumes that if -o is not passed then if an object directory does not already exist then it should build in the source directories. The normal buildworld process will have already ran 'make obj' in each of the component directories so this is not a problem. With WITH_AUTO_OBJ though this is not the case. So we must tell crunchgen(1) that MK_AUTO_OBJ=yes will create the directory and to not require it be present before generating its Makefile. Sponsored by: EMC / Isilon Storage Division
* DIRDEPS_BUILD: Update dependencies.bdrewery2016-05-261-0/+1
| | | | Sponsored by: EMC / Isilon Storage Division
* rmextattr(8) man page clarifications regarding -qqasomers2016-05-261-1/+2
| | | | | | | | Reviewed by: ngie MFC after: 6 days X-MFC-With: 299085 Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6422
* bsdinstall: unbreak static address assignment for wired networks.avos2016-05-261-1/+5
| | | | | | | This fixes regression introduced in r298946 (fixes static address assignment for wireless networks). Reported & submitted by: allanjude
* Avoid buffer overflow or truncation when constructing path_zoneinfo_file.truckman2016-05-261-1/+3
| | | | | | Reported by: Coverity CID: 1011160 MFC after: 1 week
* Make code compile when basename() is POSIX compliant.ed2016-05-251-4/+8
| | | | | | | | | The POSIX basename() function is allowed to modify its input buffer, which means its argument is "char *". Pull a copy of the input string before computing the base. Reviewed by: jtl Differential Revision: https://reviews.freebsd.org/D6465
* Fix Coverity CIDs 1340544 Resource leak and 1340543 Use after freetruckman2016-05-253-5/+9
| | | | | | | | | | | | | | | | | | | | | | | At line 479 of ldapclient.c in client_build_req(), the error return leaks ldap_attrs (CID 1340544). It looks like this can happen if the first utoa() call in aldap_get_stringset() fails. It looks like other leaks can happen if other utoa() calls fail since scanning this array when it is freed stops when the first NULL is encountered. Fix these problems by not storing NULL in the array when utoa() fails, and by freeing ret and returning NULL if nothing is stored in the array. That way the caller will never see the ldap_attrs[0] == NULL case, so delete that check. The ber_printf_element() calls ber_free_elements() on its ber argument and returns NULL on failure. When each of its callers detects failure, they do a goto fail, which then calls ber_free_elements() with the same pointer (CID 1340543). Fix is to delete the ber_free_elements() from ber_printf_element() Reported by: Coverity CID: 1340543, 1340544 Reviewed by: araujo Differential Revision: https://reviews.freebsd.org/D6550
OpenPOWER on IntegriCloud