| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Consider the negation operator (!) to be a word even if it is not followed
by whitespace. This allows "optional !foo" which is what most programmers
are naturally going to tend to do as opposed to "optional ! foo".
Fix the negation (!) operator so that it binds only to the word that
immediately follows it.
|
|
|
|
|
|
|
|
| |
Setgid before running a command as a specified user. Previously only
initgroups(3) was called, what isn't quite enough. This brings jail(8)
in line with jexec(8), which was already doing the right thing.
PR: 195984
|
| |
|
|
|
|
|
|
|
|
|
| |
Add configuration options to override physical and UNMAP blocks geometry.
While in most cases CTL should correctly fetch those values from backing
storages, there are some initiators (like MS SQL), that may not like large
physical block sizes, even if they are true. For such cases allow override
fetched values with supported ones (like 4K).
|
| |
|
| |
|
|
|
|
|
| |
Errata: FreeBSD-EN-14:13.freebsd-update
Approved by: so@
|
|
|
|
|
|
| |
Document use of wildcards (*) and ampersands (&) in autofs map files.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Make the auto_master(5) man page clearer on how auto_master
and map files work together, and add example for smbfs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
The "intr" option is NFS-specific; fix examples in auto_master(5).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
| |
Increase the buffer size to keep the list of programm names when
parsing programm specification. It is safe to not check out of bounds
access, because !isprint(p[i]) check will stop reading, when '\0'
character will be read from the input string.
Sponsored by: Yandex LLC
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Count consecutive read requests as blocking in CTL for files and ZVOLs.
Technically read requests can be executed in any order or simultaneously
since they are not changing any data. But ZFS prefetcher goes crasy when
it receives consecutive requests from different threads. Since prefetcher
works on level of separate blocks, instead of two consecutive 128K requests
it may receive 32 8K requests in mixed order.
This patch is more workaround then a real fix, and it does not fix all of
prefetcher problems, but it improves sequential read speed by 3-4x times
in some configurations. On the other side it may hurt performance if
some backing store has no prefetch, that is why it is disabled by default
for raw devices.
|
|
|
|
|
| |
This fixes problem with ctld reload when it is configured to listen on two
portals with same IP, but different ports.
|
|
|
|
|
|
| |
Add HISTORY section to ctld(8).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for sending redirections to iSCSI target.
MFC r274309:
Fix several nits in redirection handling - don't use wrong CSG,
and avoid use-after-free.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
ctld(8) doesn't require -lcam or -lssl; remove those from DPADD and LDADD.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
gpioctl: don't print the command line arguments.
PR: 195330
Submitted by: Scott Ellis jumpnowtek at gmail.com
|
| |
|
|
|
|
|
|
| |
Fix some bugs in the error handling of getdevice().
PR: 194506
|
|
|
|
| |
Fix memory leak, reported by Coverity.
|
|
|
|
|
|
| |
Improve wording in ctl.conf(5).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix iscsictl(8) and ctld(8) to correctly handle Windows newlines
(CRLF) in iscsi.conf and ctl.conf.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Keep the token list sorted.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to optionally use semicolon to separate statements.
This makes it possible to format stuff like this:
target xxx {
lun 0 { path /foo/bar; size 4G; }
}
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Simplify code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.
|
|
|
|
|
|
| |
Fix build after previous commit. While here, improve error messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Remove the distinction between strings and numbers from ctld(8) yacc parser.
This fixes problems with passing strings that look like numbers to clauses
that expect strings; previously it caused syntax errors and had to be worked
by user, using quotes. The workaround introduced in r267833 is no longer
neccessary.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following -Werror warnings from clang 3.5.0, while building
bsnmpd's snmp_hostres module:
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:204:20: error: absolute value function 'abs' given an argument of type 'const long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value]
str[9] = (u_char)(abs(tm->tm_gmtoff) / 3600);
^
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:204:20: note: use function 'labs' instead
str[9] = (u_char)(abs(tm->tm_gmtoff) / 3600);
^~~
labs
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:205:22: error: absolute value function 'abs' given an argument of type 'const long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value]
str[10] = (u_char)((abs(tm->tm_gmtoff) % 3600) / 60);
^
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:205:22: note: use function 'labs' instead
str[10] = (u_char)((abs(tm->tm_gmtoff) % 3600) / 60);
^~~
labs
Since tm::tm_gmtoff is a long, use labs(3) instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following -Werror warnings from clang 3.5.0, while building
usr.sbin/rtadvd:
usr.sbin/rtadvd/rtadvd.c:1291:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
abs(preferred_time - pfx->pfx_pltimeexpire) > rai->rai_clockskew) {
^
usr.sbin/rtadvd/rtadvd.c:1291:7: note: remove the call to 'abs' since unsigned values cannot be negative
abs(preferred_time - pfx->pfx_pltimeexpire) > rai->rai_clockskew) {
^~~
usr.sbin/rtadvd/rtadvd.c:1324:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
abs(valid_time - pfx->pfx_vltimeexpire) > rai->rai_clockskew) {
^
usr.sbin/rtadvd/rtadvd.c:1324:7: note: remove the call to 'abs' since unsigned values cannot be negative
abs(valid_time - pfx->pfx_vltimeexpire) > rai->rai_clockskew) {
^~~
2 errors generated.
These warnings occur because both preferred_time and pfx_pltimeexpire
are uint32_t's, so the subtraction expression is also unsigned, and
calling abs() is a no-op.
However, the intention was to look at the absolute difference between
the two unsigned quantities. Introduce a small static function to
clarify what we're doing, and call that instead.
Reviewed by: hrs
Differential Revision: https://reviews.freebsd.org/D1197
|
|
|
|
|
|
| |
Improve ctld.conf example.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Fix ctl.conf example to use proper paths to ZVOLs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Comment out parts about iSER; it's not implemented.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the initiator-name and initiator-portal checks a little nicer.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Tidy up the login code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.
Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.
Relnotes: Yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
| |
Make both iSCSI initiator and target support base64 encoded CHAP data.
While all tested initiators and targets use hex-encoded CHAP data, RFC also
allows base64 encoding there, and Microsoft certificaition tool uses it.
|
|
|
|
|
|
| |
Clean up (refactor) discovery a little; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove misleading statement. Bump date.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove spurious empty line.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix ctld(8) to not show the "auth-group <name> not assigned to any target"
warning for auth-groups assigned to a portal-group.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Whitespace fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use keys_add_int() where appropriate. No functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Untangle iSCSI authentication code by splitting off the CHAP
implementation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
| |
Add to CTL support for logical block provisioning threshold notifications.
For ZVOL-backed LUNs this allows to inform initiators if storage's used or
available spaces get above/below the configured thresholds.
Sponsored by: iXsystems, Inc.
|
|
|
|
|
| |
Decode more fields when dumping USB descriptors.
- Some minor style changes while at it.
|
|
|
|
|
|
| |
Fix automountd(8) not to leave zombies.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Remove call to access(2) which didn't serve any purpose, and make it more
tolerant to errors.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Make automount(8)/automountd(8) treat percent sign as a valid part
of path. It's useful for spaces encoded as %20 as msdosfs labels.
Submitted by: glebius@
|