| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
ctld(8) doesn't require -lcam or -lssl; remove those from DPADD and LDADD.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
gpioctl: don't print the command line arguments.
PR: 195330
Submitted by: Scott Ellis jumpnowtek at gmail.com
|
| |
|
|
|
|
|
|
| |
Fix some bugs in the error handling of getdevice().
PR: 194506
|
|
|
|
| |
Fix memory leak, reported by Coverity.
|
|
|
|
|
|
| |
Improve wording in ctl.conf(5).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix iscsictl(8) and ctld(8) to correctly handle Windows newlines
(CRLF) in iscsi.conf and ctl.conf.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Keep the token list sorted.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to optionally use semicolon to separate statements.
This makes it possible to format stuff like this:
target xxx {
lun 0 { path /foo/bar; size 4G; }
}
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Simplify code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.
|
|
|
|
|
|
| |
Fix build after previous commit. While here, improve error messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Remove the distinction between strings and numbers from ctld(8) yacc parser.
This fixes problems with passing strings that look like numbers to clauses
that expect strings; previously it caused syntax errors and had to be worked
by user, using quotes. The workaround introduced in r267833 is no longer
neccessary.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following -Werror warnings from clang 3.5.0, while building
bsnmpd's snmp_hostres module:
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:204:20: error: absolute value function 'abs' given an argument of type 'const long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value]
str[9] = (u_char)(abs(tm->tm_gmtoff) / 3600);
^
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:204:20: note: use function 'labs' instead
str[9] = (u_char)(abs(tm->tm_gmtoff) / 3600);
^~~
labs
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:205:22: error: absolute value function 'abs' given an argument of type 'const long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value]
str[10] = (u_char)((abs(tm->tm_gmtoff) % 3600) / 60);
^
usr.sbin/bsnmpd/modules/snmp_hostres/hostres_snmp.c:205:22: note: use function 'labs' instead
str[10] = (u_char)((abs(tm->tm_gmtoff) % 3600) / 60);
^~~
labs
Since tm::tm_gmtoff is a long, use labs(3) instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following -Werror warnings from clang 3.5.0, while building
usr.sbin/rtadvd:
usr.sbin/rtadvd/rtadvd.c:1291:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
abs(preferred_time - pfx->pfx_pltimeexpire) > rai->rai_clockskew) {
^
usr.sbin/rtadvd/rtadvd.c:1291:7: note: remove the call to 'abs' since unsigned values cannot be negative
abs(preferred_time - pfx->pfx_pltimeexpire) > rai->rai_clockskew) {
^~~
usr.sbin/rtadvd/rtadvd.c:1324:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
abs(valid_time - pfx->pfx_vltimeexpire) > rai->rai_clockskew) {
^
usr.sbin/rtadvd/rtadvd.c:1324:7: note: remove the call to 'abs' since unsigned values cannot be negative
abs(valid_time - pfx->pfx_vltimeexpire) > rai->rai_clockskew) {
^~~
2 errors generated.
These warnings occur because both preferred_time and pfx_pltimeexpire
are uint32_t's, so the subtraction expression is also unsigned, and
calling abs() is a no-op.
However, the intention was to look at the absolute difference between
the two unsigned quantities. Introduce a small static function to
clarify what we're doing, and call that instead.
Reviewed by: hrs
Differential Revision: https://reviews.freebsd.org/D1197
|
|
|
|
|
|
| |
Improve ctld.conf example.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Fix ctl.conf example to use proper paths to ZVOLs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Comment out parts about iSER; it's not implemented.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the initiator-name and initiator-portal checks a little nicer.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Tidy up the login code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.
Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.
Relnotes: Yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
| |
Make both iSCSI initiator and target support base64 encoded CHAP data.
While all tested initiators and targets use hex-encoded CHAP data, RFC also
allows base64 encoding there, and Microsoft certificaition tool uses it.
|
|
|
|
|
|
| |
Clean up (refactor) discovery a little; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove misleading statement. Bump date.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove spurious empty line.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix ctld(8) to not show the "auth-group <name> not assigned to any target"
warning for auth-groups assigned to a portal-group.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Whitespace fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use keys_add_int() where appropriate. No functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Untangle iSCSI authentication code by splitting off the CHAP
implementation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
| |
Add to CTL support for logical block provisioning threshold notifications.
For ZVOL-backed LUNs this allows to inform initiators if storage's used or
available spaces get above/below the configured thresholds.
Sponsored by: iXsystems, Inc.
|
|
|
|
|
| |
Decode more fields when dumping USB descriptors.
- Some minor style changes while at it.
|
|
|
|
|
|
| |
Fix automountd(8) not to leave zombies.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Remove call to access(2) which didn't serve any purpose, and make it more
tolerant to errors.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Make automount(8)/automountd(8) treat percent sign as a valid part
of path. It's useful for spaces encoded as %20 as msdosfs labels.
Submitted by: glebius@
|
|
|
|
|
|
|
| |
Silence down a warning that doesn't provide any useful information unless
debug is enabled.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
10-stable branch, this makefile had WARNS=2, and on head the value is
still 2, but in the MFC done in r274082 it got changed to 3, causing build
failures when building with gcc. This direct commit to 10 goes back to
WARNS=2.
|
|
|
|
|
|
| |
Rewrite some of the disk setup documentation to be clearer and contain
less obsolete information. Also move the entropy command down the list --
the list is ordered by likelihood of use rather than alphabetically.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test for bug 191427 where pw(8) will go into an infinite loop
Add some tests for modifying groups
When a group is renamed then the group has been invalidated for sure.
In that case get the group information using the new name.
Fix a regression in pw usermod -G list
The user was perperly adding the to different groups from "list" but was not
removed from the other groups it could have belong to.
Do not delete the group wheel when bad argument is passed to pw groupdel -g
Check that the -g argument is actually a number, if not report an error.
This argument is converted without checking with atoi(3) later so without this
check it converts any alpha entries into 0 meaning it deletes the group wheel
Ensure pw userdel -u <invalid> do not try to remove root
Check the uid passed is actually a number as early as possible
Fix renaming a group via the gr_copy function
Add a regression test to pw(8) because the bug was discovered via using:
pw groupmod
PR: 193704 [1], 185666 [2], 90114 [3], 187189 [4]
Submitted by: Marc de la Gueronniere [4]
Reported by: az [1], sub.mesa@gmail.com [2], bkoenig@cs.tu-berlin.de [3],
mcdouga9@egr.msu.edu [4]
|
|
|
|
|
| |
- Cleanups pc98 code.
- Remove unworked formats.
|
|
|
|
|
|
|
|
| |
Clarify the documentation of pmcstat:
the -d argument should be passed before -p, -s, -P or -S to be taken in account
Differential Revision: https://reviews.freebsd.org/D1011
Reviewed by: adrian, gnn
|
|
|
|
|
|
|
|
|
|
| |
Rework the EXAMPLES section to be a bit clearer.
- Add an example of using etcupdate diff.
- Create a subsection on bootstrapping that is below the simple
examples. This should make it clearer that 'etcupdate extract' is
a one-time operation and not part of the common workflow. It also
adds more suggestions on when bootstrapping is needed and additional
steps to make future merges simpler.
|
|
|
|
| |
Add "rpm" and "formfactor" LUN options to match istgt functionality.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To restore the default font using vidcontrol(1), use the "-f" flag
without an argument:
vidcontrol -f < /dev/ttyv0
PR: 193910
Differential Revision: https://reviews.freebsd.org/D971
Submitted by: Marcin Cieslak <saper@saper.info>
Reviewed by: ray@, emaste@
Approved by: ray@
MFC of: r273544
|
|
|
|
|
|
| |
Add ZFS support to the bsdinstall partition editor and sade
Submitted by: Kurt Lidl (original version)
|
|
|
|
|
|
| |
Fix the watchdog/watchdog man pages.
The default timeout is 128 seconds.
|
|
|
|
|
|
|
| |
If we fail to send a signal after rotation, print the pidfile from which
the corresponding PID was obtained.
PR: 194143
|
|
|
|
|
|
|
|
| |
lpr: replace setpgrp(2) with setpgid(2).
setpgid(2) is more portable than setpgrp(2).
The BSD variant of setpgrp is a wrapper for
setpgid(2) anyways.
|
|
|
|
|
|
|
|
|
|
|
| |
Convert LIBCURSES to LIBNCURSES to fix "make checkdpadd"
Also, add a missing LIBPANEL dependency for lldb
Approved by: rpaulo (mentor)
Suggested by: brooks
Phabric: D675 (as part of a larger diff)
PR: 192762
|
|
|
|
| |
Fix memory leak in sandboxed namei lookup. [SA-14:22]
|
|
|
|
|
|
| |
Make this subcommand less FC-specific, reporting target and port addresses
in more generic way. Also make it report list of connected initiators in
unified way, working for both FC and iSCSI, and potentially others.
|