summaryrefslogtreecommitdiffstats
path: root/usr.sbin/syslogd/syslogd.c
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'origin/stable/10' into develdevelRenato Botelho2017-02-231-7/+7
|\
| * MFC r313356:ngie2017-02-141-1/+1
| | | | | | | | Fix typos in comments (returing -> returning)
| * MFC r313358,r313360:ngie2017-02-141-6/+6
| | | | | | | | | | | | | | | | | | | | r313358: Sort sys/ #includes and zap an unnecessary trailing space nearby r313360: Sort sys/ #includes some more
* | Merge remote-tracking branch 'origin/stable/10' into develRenato Botelho2016-04-111-1/+1
|\ \ | |/
| * MFC r294924asomers2016-04-081-1/+1
| | | | | | | | | | | | | | | | | | syslogd: Enable repeated line compression for lines of any length. Enable repeated line compression for lines of any length, instead of only short lines. AFAICT repeated line compression was limited to short lines as a RAM optimization, which made sense when karels added it in 1988, but no longer. The penalty is a paltry 904B of RAM per file logged.
* | Merge remote-tracking branch 'origin/stable/10' into develRenato Botelho2016-01-131-4/+8
|\ \ | |/
| * MFC r279567, r279568: Add and document an option to cause syslogd to runrpokala2016-01-091-4/+8
| | | | | | | | | | | | | | | | | | | | in the foreground. This allows a separate process to monitor when and how syslogd exits. That process can then restart syslogd if needed. Approved by: jhb Sponsored by: Panasas, Inc.
* | Merge branch 'stable/10' into develRenato Botelho2015-11-031-8/+20
|\ \ | |/
| * MFC r286304:ngie2015-10-251-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Set f_file to -1/F_UNUSED when after closing when possible This will help ensure we don't trash file descriptors that get used later on in the daemon Found via internal Coverity scan Discussed with: cem, ed, markj Differential Revision: https://reviews.freebsd.org/D3081 Submitted by: Miles Ohlrich <miles.ohlrich@isilon.com> Sponsored by: EMC / Isilon Storage Division
* | Importing pfSense patch syslogd.c.diffRenato Botelho2015-08-171-5/+123
|/
* MFC r279016:ed2015-03-151-1/+2
| | | | | | | | | | | | | | Make syslogd work in case shutdown() is POSIX-ly correct. On POSIX conformant systems, shutdown() should return ENOTCONN when not connected. We attempted to fix this once (kern/84761), but this change got backed out because it 'breaks code' (r150155). I just reapplied the patch and indeed, syslogd fails on startup. Make it easier to re-enable this change in the future by paching up syslogd to do the right thing. Sponsored by: Nuxi
* MFC r278297:dim2015-02-091-4/+2
| | | | | | | | | | | | | | | | | Fix two clang 3.6.0 warnings in usr.sbin/syslogd: usr.sbin/syslogd/syslogd.c:1023:10: error: address of array 'f->f_prevline' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] f->f_prevline && !strcmp(msg, f->f_prevline) && ~~~^~~~~~~~~~ usr.sbin/syslogd/syslogd.c:1178:16: error: address of array 'f->f_prevline' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] } else if (f->f_prevline) { ~~ ~~~^~~~~~~~~~ In both cases, the f_prevline field of struct filed is a char array, so it can never be null. Remove the checks. Reviewed by: jilles Differential Revision: https://reviews.freebsd.org/D1716
* MFC r275729:ae2014-12-191-2/+2
| | | | | | | | | Increase the buffer size to keep the list of programm names when parsing programm specification. It is safe to not check out of bounds access, because !isprint(p[i]) check will stop reading, when '\0' character will be read from the input string. Sponsored by: Yandex LLC
* MFC r258076, r258077:ian2013-12-141-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes 3 problems in syslogd related to sizing receive buffers... - A call was misplaced at the wrong level of nested if blocks, so that the buffers for unix domain sockets (/dev/log, /dev/klog) were never increased at all; they remained at a way-too-small default size of 4096. - The function that was supposed to double the size of the buffer sometimes did nothing, and sometimes installed a wildly-wrong buffer size (either too large or too small) due to an unitialized 'slen' variable passed to getsockopt(). Most often it doubled the UDP buffers from 40k to 80k because accidentally there would be harmless stack garbage in the unitialized variables. - The whole concept of blindly doubling a socket's buffer size without knowing what size it started at is a design flaw that has to be called a bug. If the double_rbuf() function had worked at all (I.E., if the other two bugs didn't exist) this would lead to UDP sockets having an 80k buffer while unix dgram sockets get an 8k buffer. There's nothing about the problem being solved that requires larger buffers for UDP than for unix dgram sockets -- the buffering requirements are the same regardless of socket type. This change renames the double_rbuf() function to increase_rbuf() and increases the buffer size on all types of sockets to 80k. 80k was chosen only because it appears to be the size the original change was shooting for, and it certainly seems to be reasonably large (I might have picked 64k in the absence of any historical guidance). Add ENETUNREACH and EADDRNOTAVAIL to the list of errors that are potentially transient and shouldn't result in closing the socket and giving up forever.
* syslogd: Use closefrom() instead of getdtablesize()/close() loop.jilles2013-04-271-3/+2
| | | | | | | | | | | When syslogd forks a process for '|' destinations, it closes all file descriptors greater than 2. Use closefrom() for this instead of a getdtablesize()/close() loop because it is both faster and avoids leaving file descriptors open because the limit was lowered after they were opened. MFC after: 1 week
* - Make sure that errno isn't modified before calling logerror() in errormarkj2012-12-201-1/+5
| | | | | | | | | | conditions. - Don't check for AF_INET6 when compiled without INET6 support. PR: bin/173930 Submitted by: Garrett Cooper <yanegomi@gmail.com> Approved by: rstone (co-mentor) MFC after: 1 week
* Add missing const keywords.ed2012-10-191-4/+4
|
* Add support for ipv6 addresses as destinationbapt2012-09-121-1/+12
| | | | | | | PR: bin/150530 Submitted by: andy white <andywhite@gmail.com> Tested by: Olivier Cochard-Labbe <olivier@cochard.me> MFC after: 1 month
* Add a new option, -N to disable the default and recommended syslogd(8)delphij2011-07-141-7/+23
| | | | | | | | behavior, which binds to the well known UDP port. This option implies -s. MFC after: 2 months
* Here v->iov_len has been assigned the return value from snprintf.dwmalone2011-01-191-2/+3
| | | | | | | | | | | | | | Checking if it is > 0 doesn't make sense, because snprintf returns how much space is needed if the buffer is too small. Instead, check if the return value was greater than the buffer size, and truncate the message if it was too long. It isn't clear if snprintf can return a negative value in the case of an error - I don't believe it can. If it can, then testing v->iov_len won't help 'cos it is a size_t, not an ssize_t. Also, as clang points out, we must always increment v here, because later code depends on the message being in iov[5].
* syslogd(8) already supports *sending* log messages to non-olli2010-08-071-4/+36
| | | | | | | | | | | | | | standard ports, but it can't *receive* them (port 514 is hardcoded). This commit adds that missing feature. (NB: I actually needed this feature for a server farm where multiple jails run with shared IP addresses, and every jail should have its own syslogd process.) As a side effect, syslogd now compiles with WARNS=6. Approved by: des (mentor) MFC after: 3 weeks
* Port all applications in usr.sbin/ from libulog to utmpx.ed2010-01-131-2/+1
|
* Let syslogd use utmpx.ed2009-12-241-25/+16
| | | | | Because strings are guaranteed to be null terminated, there is no need for excessive copying of strings, such as the line name.
* Avoid sshd, cron, syslogd and inetd to be killed under high-pressure swapattilio2009-11-251-0/+4
| | | | | | | | | | | | | | environments. Please note that this can't be done while such processes run in jails. Note: in future it would be interesting to find a way to do that selectively for any desired proccess (choosen by user himself), probabilly via a ptrace interface or whatever. Obtained from: Sandvine Incorporated Reviewed by: emaste, arch@ Sponsored by: Sandvine Incorporated MFC: 1 month
* Constify 'name' field in struct funix. This commit makes syslogd(8)delphij2008-12-191-1/+1
| | | | | WARNS?=6 on amd64 but I have not tested under universe so keep WARNS?= level as-is for now.
* Fixing !INET6 builds after bumping WARNS to 3.avatar2008-12-181-2/+8
|
* Use passed parameter rather than the #define.obrien2008-12-171-2/+2
| | | | (more accurate extraction of Juniper Networks change)
* Rather than hardcode the 'struct iovec iov' array size, use a #define.obrien2008-12-171-10/+12
| | | | | | While I'm here bump WARNS to 3. Obtained from: Juniper Networks
* Add a flag, -T, that tells syslogd to always replace the timestamp ondwmalone2008-09-251-7/+12
| | | | | | | | | | messages from the network. We already replace malformatted timestamps and this option lets us replace timestamps that are correctly formatted but wrong. PR: 120891 Submitted by: Thomas Vogt <thomas@bsdunix.ch> MFC after: 1 week
* Remove extraneous NULL pointer check - the pointer is guaranteed to be non-NULL.obrien2008-09-011-2/+1
|
* Allow comment to be placed at the end of a configuration line.sobomax2008-07-091-0/+11
| | | | MFC after: 2 weeks
* Add a -8 switch to syslogd to prevent it from mangling 8-bit data.brian2008-05-141-3/+7
|
* Two no-op fixes to improve corretness of syslogd code:dwmalone2008-02-201-3/+4
| | | | | | | | | | | 1) Use [AP]F_LOCAL rather than [AP]F_UNIX. 2) When copying a pipe's name, use f->f_un.f_pipe.f_pname, not f->f_un.f_fname. PR: 20889 Submitted by: Damieon Stark PR: 116642 Submitted by: Jim Pirzyk Reviewed by: md5
* + Open ctty in non-blocking mode to avoid hangs during open and close(waitingobrien2007-12-111-9/+20
| | | | | | | | | | | | | | for the port to drain). + Handle "*" as a priority properly. + Test what is free'ed. + Dynamically determine length vs. hardcoding it. + Free the previous message buffer (f_prevline) only after logging all the messages and just before the process exit. Also check f_prevline for NULL before using it. + The time displayed is not synchornized with the other log destinations. + Fix a comment. Obtained from: Juniper Networks
* style(9)obrien2007-12-051-15/+15
|
* Sync usage() with manpage's SYNOPSIS.ru2006-09-291-2/+2
|
* Add the ability to log to an arbitrary udp port as well as thejulian2006-04-171-6/+40
| | | | | standard syslog port. This allows syslog to easily export lines of interest to an external logging system.
* Currently, if writing out a log entry fails, we unlink that log entry from ourcsjp2006-03-301-5/+12
| | | | | | | | | | | | internal list of logfiles. So if writev(2) fails for potentially transient errors like ENOSPC, syslogd requires a restart, even if the filesystem has purged. This change allows syslogd to ignore ENOSPC space errors, so that when the filesystem is cleaned up, syslogd will automatically start logging again without requiring the reset. This makes syslogd(8) a bit more reliable. MFC after: 1 week
* By default (for security reasons) syslogd(8) doesn't create log filespjd2006-03-061-3/+7
| | | | | | | | | | | | when they don't exist, but sometimes its quite useful (eg. we use non-standard log files and memory backed /var/, which is populated on boot). Add -C option which tells syslogd(8) to create log files if they don't exist. Glanced at by: phk MFC after: 3 days
* style(9) nitlet:imp2005-10-171-1/+2
| | | | | | | | | | | foo() { } to foo() { }
* setsockopt() will return -1 on error, not 0.cognet2005-09-281-1/+1
| | | | Pointy hat to: Jeremie Le Hen
* Use SO_REUSEADDR on the socket, to make the use of syslogd in jails easier.cognet2005-09-281-1/+7
| | | | Submitted by: Jeremie Le Hen <jeremie le-hen org>
* Use pidfile(3) in syslogd(8).pjd2005-08-241-9/+16
|
* Add cases for ENOBUFS and ENETDOWN. We need to make sure that wecsjp2005-05-191-0/+2
| | | | | | | | | catch all transient errors. This fixes situations where transient error conditions such as network interfaces losing carrier signals or the system running out of mbufs would result in the permanent removal of forwarding syslog messages. MFC after: 1 week
* NI_WITHSCOPEID cleanup. Neither RFC 2553 nor RFC 3493 definesume2005-05-131-17/+5
| | | | | NI_WITHSCOPEID, and our getaddrinfo(3) does nothing special for it, now.
* Add -S option which allows to change the pathname of the privilegedhrs2005-04-131-1/+6
| | | | | | | socket /var/run/logpriv. Reviewed by: glebius and kensmith MFC after: 2 days
* Check that supplied facility is not bigger than LOG_NFACILITIES.glebius2005-03-281-0/+7
| | | | | PR: bin/79260 Submitted by: Shuichi KITAGUCHI
* Allow ':' and '%' in hostname specifications so that we can specify IPv6dwmalone2004-12-281-1/+1
| | | | | | addresses and scope IDs. MFC after: 3 weeks
* Some syslog messages delimit the program tag with whitespace ratherdwmalone2004-12-281-2/+2
| | | | | | | | | | | | than a colon, so don't allow whitespace in program names. To be consistent with hostnames, don't allow whitespace in the program name specifiers in syslog.conf either. (The first change is by Markus from the PR, the second is mine.) PR: 68691 Submitted by: Markus Oestreicher <m.oe@x-trader.de> MFC after: 3 weeks
* Fix a minor comment typo: priveleged = privileged.keramida2004-11-181-1/+1
|
OpenPOWER on IntegriCloud