| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
from their liceense.
Obtained from: NetBSD
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interfaces (such as when you are part of a carp pool), and you run
rpcbind -h to restrict which interfaces have rpc services, rpcbind can
none-the-less return addresses that aren't in the -h list. This patch
enforces the rule that when you specify -h on the command line, then
services returned from rpcbind must be to one of the addresses listed
in -h, or be a loopback address (since localhost is implicit when
running -h).
The root cause of this is the assumption in addrmerge that there can
be only one interface that matches a given network IP address. This
turns out not to be the case. To retain historical behavior, I didn't
try to fix the routine to prefer the address that the request came
into, since I didn't know the side effects that might cause in the
normal case. My quick analysis suggests that it wouldn't be a
problem, but since this code is tricky I opted for the more
conservative patch of only restricting the reply when -h is in effect.
Hence, this change will have no effect when you are running rpcbind
without -h.
Reviewed by: alfred@
Sponsored by: iX Systems
MFC after: 2 weeks
|
|
|
|
|
|
| |
stack garbage.
Obtained from: NetBSD 1.13
|
| |
|
|
|
|
|
|
|
|
|
| |
for rpcbind(8) to crash.
The crash was due to a boolean variable initialized
improperly. Besides fixing the initialization, pick
a better name for the variable so that its meaning is
clear and no more coding errors appear around it.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
PR: bin/1122566
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
|
|
| |
other than INADDR_ANY.
2) Add the -6 option to specify "IPv6 only".
Glanced at by: bms
Requested by: bms [2]
PR: bin/84494 [1]
Approved by: silence from maintainer (~2 weeks) [1]
MFC after: 2 weeks
|
| |
|
|
|
|
|
|
| |
PR: docs/105720
Submitted by: koitsu
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
http://lists.freebsd.org/pipermail/freebsd-current/2006-March/061725.html
The src.conf(5) manpage is to follow in a few days.
Brought to you by: imp, jhb, kris, phk, ru (all bugs are mine)
|
|
|
|
|
| |
are exported by libc with prototypes in our standard headers.
I guess at one time this was necessary, but not any longer.
|
|
|
|
|
|
| |
PR: kern/73865
Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com>
MFC after: 3 days
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Decrease log severity to debug if a protocol is not supported by the
kernel (rpcbind checks /etc/netconfig if a protocol is available).
This avoids "rpcbind: cannot create socket for tcp6" messages
at startup on IPv4-only kernels.
|
|
|
|
| |
Obtained from: NetBSD
|
|
|
|
| |
Obtained from: NetBSD
|
| |
|
|
|
|
|
|
|
|
| |
produce backcompatible code.
Reviewed by: rwatson
Obtained from: NetBSD
MFC after: 1 day
|
|
|
|
| |
especially in troff files.
|
|
|
|
| |
Add FreeBSD Id tag where missing.
|
|
|
|
|
|
|
|
|
| |
from "unix" back to "local". Add some compat stuff so both
ways work for some time.
Reviewed by: phk
Approved by: imp (UPDATING)
Requested by: iedowse, lukem@netbsd.org
|
|
|
|
|
|
|
|
|
| |
Fixes segfault if rpcbind is started up a second time.
Solution has been taken from mountd(8).
Reviewed by: phk
Approved by: re (rwatson)
|
|
|
|
|
|
|
| |
Added the -h option to the synopsis, documented the -a option,
sorted options descriptions according to style(9).
Approved by: re
|
|
|
|
| |
Requested by: mike
|
|
|
|
| |
needed to avoid warnings about comparing signed and unsigned values.
|
| |
|
| |
|
|
|
|
| |
of compound statement' warnings.
|
|
|
|
| |
Submitted by: kris
|
|
|
|
| |
MFC after: 1 week
|
| |
|
|
|
|
|
|
| |
UDP requests.
Submitted by: mbr
|
|
|
|
|
| |
ugly explicit casts, and its argument doesn't need explicitly cast to u_int,
especially if sizeof() is being used.
|
|
|
|
| |
sentences.
|
|
|
|
|
| |
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use '\0' for a char instead of NULL.
- Explicitly compare against the global `nullstring' to determine if
a non-NULL uaddr is not malloc'd.
- Remove some unnecessary casting of the argument to free().
- In rpcbproc_callit_com(), move the freeing of m_uaddr to the
cleanup code at the end of the function.
- To avoid confusion and possible alignment problems, change
netbufdup() to allocate the netbuf struct and the sockaddr buffer
separately, and change netbuffree() accordingly. This makes it
produce netbufs that are consistent with all other netbufs in
rpcbind.
|
|
|
|
| |
the netbuf before freeing the netbuf structure itself.
|
|
|
|
|
| |
Fix an off-by-one error in logit() when determining if a procedure
number has a known name.
|
|
|
|
|
|
|
|
|
|
|
|
| |
comparing bit by bit.
Make the logic in in6_fillscopeid() match that in our ifconfig(8):
only set the scope ID if there is one in the address and none in
sin6_scope_id.
Correct a comment in network_init() that didn't make sense; it was
probably never updated after it was pasted from similar code in
addrmerge().
|
| |
|
|
|
|
|
|
| |
debugging fprintf.
Submitted by: Martin Blapp <mb@imp.ch>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contained a number of memory leaks. The changes include:
- Add a comment describing what addrmerge() does.
- Deal with 0.0.0.0./::. or AF_LOCAL callers correctly.
- Use rpcbind_get_conf() instead of getnetconfigent() so we don't
have to remember to free the returned netconfig struct.
- Make just one pass through the ifaddrs list; we can pick up a fallback
interface address in the same pass as the netmask comparison.
- Define and use SA2SIN* macros to avoid the need for loads of
protocol-specific local variables.
- Use mostly protocol-independent code for building the netbuf version
of the address to be returned.
- Use the common cleanup code for virtually all error and non-error
cases, fixing a number of memory leaks.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function has a return type of u_int32_t, into which it was somehow
supposed to encode:
* A valid 32-bit XID (which could be any value including 0).
* 0, meaning a duplicate request.
* -1, meaning a malloc failed (!);
We now ensure that all XIDs are non-zero, and pass the XID out via
a pointer argument.
In forward_find() and free_slot_by_xid(), remove an unnecessary
and confusing test for a negative result from an unsigned modulo
operation, but add an unnecessary cast to highlight why.
|