| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Fix a ton of speelling errors
|
|
|
|
|
|
|
|
| |
newsyslog.conf: allow to configure the signal using the signal name.
Submitted by: Alexandre Perrin <alex@kaworu.ch>
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D3961
|
|
|
|
|
|
|
| |
If we fail to send a signal after rotation, print the pidfile from which
the corresponding PID was obtained.
PR: 194143
|
|
|
|
|
|
|
| |
Fix newsyslog(8) to use the size of the file instead of the blocks it
takes on disk, as advertised in newsyslog.conf(5).
Approved by: bapt (mentor, implicit)
|
|
|
|
| |
Initialize the struct tm before handing it to strptime(3).
|
|
|
|
| |
Submitted by: dt71@gmx.com
|
|
|
|
|
|
| |
PR: bin/179122
Submitted by: Oliver Fromme <olli@secnetix.de>
MFC after: 3 days
|
|
|
|
|
|
|
|
|
|
|
| |
returning directory entries through readdir(3). In this case we need to
obtain the file type ourselves; otherwise newsyslog -t will not be able to
find archived log files and will fail to both delete old log files and to
do interval-based rotations properly.
Reported by: jilles
Reviewed by: jilles
MFC after: 2 weeks
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the most-recently archived logfile and use its mtime to determine whether
or not to rotate, as in the non-timestamped case.
Previously we would just try to use the mtime of <logfile>.0, which always
results in a rotation since it generally doesn't exist in the -t case.
PR: bin/166448
Approved by: emaste (co-mentor)
Tested by: Marco Steinbach <coco executive-computing.de>
MFC after: 2 weeks
|
|
|
|
|
|
|
| |
other fields in struct sigwork_entry.
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
that uses the 'R' flag.
Reviewed by: gad
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
|
|
| |
the corresponding struct sigwork_entry were left uninitialized,
potentially causing an early return from do_sigwork(). Ensure that these
fields are initialized, and handle the 'R' flag properly in
do_sigwork().
PR: bin/175330
Reviewed by: gad
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
| |
ensures that the next rotation happens at the correct time when using
interval-based rotations.
PR: bin/174438
Reviewed by: gad
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
|
|
| |
privileges.
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
| |
Approved by: rstone (co-mentor)
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
| |
In addition to adding missing `static' keywords:
- bin/dd: Pull in `extern.h' to guarantee consistency with source file.
- libexec/rpc.rusersd: Move shared globals into an extern.h.
- libexec/talkd: Move `debug' and `hostname' into extern.h.
- usr.bin/cksum: Put counters in extern.h, as they are used by ckdist/mtree.
- usr.bin/m4: Move `end_result' into extern.h.
- usr.sbin/services_mkdb: Move shared globals into an extern.h.
|
|
|
|
|
|
|
| |
specified.
Submitted by: Ilya A. Arkhipov
MFC after: 1 week
|
|
|
|
|
|
|
|
|
|
| |
Introduce dirfd() libc exported symbol replacing macro with same name,
preserve _dirfd() macro for internal use.
Replace dirp->dd_fd with dirfd() call. Avoid using dirfd as variable
name to prevent shadowing global symbol.
Sponsored by: Google Summer Of Code 2011
|
|
|
|
|
|
| |
leads to newsyslog rotating on (size OR time) if both are specified.
PR: 100018, 160432
|
|
|
|
|
|
| |
too.
Submitted by: Ben Kaduk <minimarmot@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
The index() and rindex() functions were marked LEGACY in the 2001
revision of POSIX and were subsequently removed from the 2008 revision.
The strchr() and strrchr() functions are part of the C standard.
This makes the source code a lot more consistent, as most of these C
files also call into other str*() routines. In fact, about a dozen
already perform strchr() calls.
|
| |
|
|
|
|
|
|
|
|
| |
- Fix memory leak
Submitted by: Slono Slono <slonoman2011@yandex.ru>
Approved by: jhb
MFC after: 1 week
|
|
|
|
|
|
|
|
|
| |
will be considered as a path to a binary or a shell script to be executed
after rotation has been completed instead of sending signal to the process
id in that file.
Sponsored by: Sippy Software, Inc.
From the: FreeBSD hacking lounge at BSDCan
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requested in newsyslog.conf. This was only the case using the non-time
based filenames (.0, .1, .2 etc.).
The change also makes newsyslog clean clean up the old extra logfile so
users don't end up with a single stale logfile which won't be rotated
out.
This change also cleans up some code a bit to avoid more copy / paste
code and removes some old copy / paste code in the process.
PR: bin/76697
MFC after: 2 weeks
|
| |
|
|
|
|
|
|
| |
local variables in the `for' loop declaration. This allows trunk
newsyslog.c to be compiled on 7.x. This change should be no-op from
the functional POV.
|
|
|
|
|
|
|
| |
Rewrite and simplify logfile compression code.
Approved by: gad
MFC after: 3 weeks
|
|
|
|
| |
MFC after: 1 week
|
|
|
|
| |
MFC after: 3 days
|
|
|
|
|
|
| |
if syslogd's -P switch or a syslogd alternative is being used.
MFC after: 3 weeks
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of the traditional simple counter.
Using the time-stamp based file-names, once a log file is archived, it
will not change name until it is deleted. This means that many backup
systems will only perform one backup of the archived log file, instead
for performing a new backup of the logfile upon each logfile rotation.
This implementation is separate from the patches in the mentioned PR,
as I wasn't aware of the existence of the PR until after I had
implemented the same functionality as the patches in the PR provide.
Unlike the PR, this new code does honor the 'log count' in
newsyslog.conf so old logfiles are deleted. This new code does not
currently support never deleting the archived logfiles.
PR: bin/29363
MFC after: 3 weeks
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Format for the include line in /etc/newsyslog.conf is:
<include> /etc/defaults/newsyslog.conf
Other notes of interest:
Globbing is supported in <include> statements.
Properly detect circular include loop dependencies.
Reviewed by: gad@
Approved by: wes@ (mentor)
MFC after: 2 months
|
|
|
|
|
|
| |
Reviewed by: gad@
Approved by: wes@ (mentor)
MFC after: 2 months
|
|
|
|
|
|
|
|
|
| |
which stops to proceed further, as it is possible that processes which
fails to create PID file get screwed by rotation.
Requested by: stas
MFC after: 2 weeks
X-MFC with: r200806
|
|
|
|
|
|
|
|
|
| |
to proceed anyway as this most likely mean that the process has been
terminated.
PR: bin/140397
Submitted by: Dan Lukes <dan obluda cz>
MFC after: 1 month
|
| |
|
|
|
|
| |
newsyslog(8) WARNS=6 clean.
|
|
|
|
|
|
|
| |
neworder change. Keep the option in a config file parser, to not
violate POLA.
MFC after: 2 weeks
|
|
|
|
|
|
| |
been bugs if the source had ever been too big for the destination.
MFC after: 3 weeks
|
|
|
|
|
|
| |
been the default for two years now, without any problems reported.
MFC after: 3 weeks
|
|
|
|
|
|
|
|
| |
they have been rotated. Among other things, use warnx() instead of warn()
for some messages where the value if errno is irrelevant to the problem
being reported.
MFC after: 5 days
|
|
|
|
|
|
| |
actual file name in error message.
MFC After: 2 weeks
|
|
|
|
|
|
|
|
|
|
| |
cojunction with -C and is used by /etc/rc.d/newsyslog.
I forgot that this was in my perforce tree and not my running system and
thus committed a non-working newsyslog script.
Reported by: des
Pointy hat: brooks
|
|
|
|
|
|
|
|
|
|
| |
parameter 2 in chmod(2), which is a mode_t (and in turn a __uint_16_t),
it's more likely that it should be defined as an unsigned variable.
This commit should make newsyslog WARNS=6 clean, but don't bump the knob
until I have a universe build.
MFC After: 1 month
|
|
|
|
| |
Pointy hat to: brooks
|
|
|
|
|
| |
path. Doing so makes no sense. I'm not sure allowing relative paths
makes sense either, but I'm not going to break that now.
|
|
|
|
|
| |
files similar to DESTDIR in the BSD make process. This only affects log
file paths not config file (-f) or archive directory (-a) paths.
|
|
|
|
|
|
|
| |
to a directory. Therefore, use stat(2) instead of lstat(2) to check if
/var/log exists.
MFC after: 7 days
|
|
|
|
| |
compiled on 4.x-stable.
|