summaryrefslogtreecommitdiffstats
path: root/usr.sbin/lpr
Commit message (Collapse)AuthorAgeFilesLines
* My recent changes to add the ctl_renametf routine assumed that print jobgad2001-11-282-21/+38
| | | | | | | | | | | control-files will always start with 'cfA*'. It turns out that some implementations of lpd (such as solaris) may send a control file which starts with 'cfB*', or really 'cf<anyLetter>*'. Although such filenames are very odd, we did used to accept them. This changes ctl_renametf to work correctly with them, and fixes up 'lpc clean' to match. PR: bin/32183 MFC after: 10 days
* Change the recently-added 'o'-processing so it maps to 'l' instead of 'f'.gad2001-11-272-10/+15
| | | | | | | | 'l' ("plain text which includes control characters") is somewhat more appropriate for 'o' ("postscript files"), and in fact some printers treat 'l' as a request to print a postscript file. MFC after: 1 week
* Fix one more compile-time warning by renaming a local variable.gad2001-10-091-3/+3
| | | | MFC after: 4 days
* Fix a compile-time warning by declaring 'len' as size_t instead of int.gad2001-10-091-1/+1
| | | | MFC after: 4 days
* Rename the local variable 'person' to 'lpr_username', to avoid compile-timegad2001-10-091-9/+9
| | | | | | warnings about conflict with a global variable used by 'lprm'. MFC after: 4 days
* Get rid of some minor compile-time errors by changing copyright/rcsidgad2001-10-091-3/+6
| | | | | | | definitions to the same format used in other lpr source files, and by adding parenthesis to the right spot in one 'if' statement. MFC after: 4 days
* Fix minor compile-time error in definition of 'copyright'.gad2001-10-091-1/+1
| | | | MFC after: 4 days
* Fix minor compile-time warning that snunk in with changes to sortq() rtn.gad2001-10-091-0/+1
| | | | MFC after: 4 days
* *** empty log message ***obrien2001-10-011-3/+4
|
* Basically rewrite the sortq() routine which is used by 'lpc clean' andgad2001-09-271-20/+126
| | | | | | | | | | 'lpc tclean'. In some obscure cases, the previous version could cause a valid user job to be removed (by 'clean'), due to invalid assumptions in the sort routine. This was a rare problem, unless ctlinfo.c is compiled with 'LEAVE_TMPCF_FILES' turned on (to check what that rtn was doing). Reviewed by: Lack of outcry on -audit and freebsd-print@bostonradio.org MFC after: 10 days
* Add minimal support for "o"-type print-file actions in lpd control files.gad2001-09-202-13/+29
| | | | | | | | | This was described in the original RFC wrt lpr, but most lpr's do not actually implement it. There is some indication that MacOS 10.1 will be using this when sending postscript files to print servers (that is what "o"-type was supposed to signify -- postscript files). MFC after: 1 week
* Fix so that lpc's interactive-mode will not be confused by EditLine processinggad2001-09-171-0/+9
| | | | | | | into thinking that there is a print-queue called 'xterm'... Reviewed by: short discussion on freebsd-stable MFC after: 1 week
* Set BINOWN=root explicitly for setuid root binaries.ru2001-09-133-0/+3
| | | | | | This is not "useless", as one may have non-default setting for BINOWN in make.conf, and we still want these to be installed setuid root in this case.
* Fix buffer overflow in queue file handling.kris2001-08-301-7/+13
| | | | | Submitted by: millert@openbsd.org, gad Reported by: X-Force <xforce@iss.net>
* mdoc(7) police: protect trailing full stops of abbreviationsru2001-08-101-1/+1
| | | | with a trailing zero-width space: `e.g.\&'.
* mdoc(7) police:ru2001-08-072-5/+3
| | | | | | | Avoid using parenthesis enclosure macros (.Pq and .Po/.Pc) with plain text. Not only this slows down the mdoc(7) processing significantly, but it also has an undesired (in this case) effect of disabling hyphenation within the entire enclosed block.
* Basically rewrite the dofork() routine, to add more error-checking andgad2001-07-231-14/+55
| | | | | | | | | correct the error-checking that was there. With the old code, an error return from getpwuid(daemon_user) could turn the lpd process into a very effective fork-bomb... Reviewed by: freebsd-audit freebsd-print (a little...) MFC after: 6 days
* Get rid of a compile-time warning by casting to (size_t).gad2001-07-231-1/+1
| | | | MFC after: 1 week
* Get rid of a compile-time warning by casting to (size_t).gad2001-07-231-1/+1
| | | | MFC after: 1 week
* Fix a few more minor compile-time warnings, mainly by using size_t wheregad2001-07-231-10/+15
| | | | | | | appropriate, and using '("%lu", (unsigned long)asizeval)' when printing something of type size_t. MFC after: 1 week
* Get rid of some compile-time warnings by defining (or casting) variablesgad2001-07-231-19/+20
| | | | | | as size_t where appropriate. MFC after: 1 week
* Fix two compile-time warnings by defining fromlen as socklen_t.gad2001-07-231-2/+2
| | | | MFC after: 1 week
* Replace calls to strncpy with calls to strlcpy, and remove the extra stepgad2001-07-223-37/+25
| | | | | | needed to ensure that the result is null-terminated when using strncpy(). MFC after: 8 days
* Rename the -w option to be -W. The recently-added -w option is differentgad2001-07-222-7/+30
| | | | | | | | than the long-standing -w option in NetBSD, so change it before anyone in FreeBSD gets used to it. For now, -w is still accepted, but prints out some warnings via syslog. MFC after: 1 week
* Change a few read & write calls to use 'STDOUT_FILENO' instead of '1'.gad2001-07-222-7/+7
| | | | | | Submitted by: David Hill <david@phobia.ms> Reviewed by: freebsd-audit (a little) MFC after: 1 week
* Perform a major cleanup of the usr.sbin Makefiles.obrien2001-07-2016-43/+65
| | | | | These are not perfectly in agreement with each other style-wise, but they are orders of orders of magnitude more consistent style-wise than before.
* Remove GCC'isms in CFLAGS.obrien2001-07-201-1/+1
|
* Remove whitespace at EOL.dd2001-07-154-8/+8
|
* Change lpd to perform sanity and safety checks on control files as itgad2001-07-154-6/+931
| | | | | | | | | | | | receives them from other hosts. This is meant to protect from both nefarious users (which maybe broke into some remote host that we accept print jobs from), and broken implementations of lpr on other platforms. This is done by changing recvjob.c to call the new ctl_renametf() routine in the new common_source/ctlinfo.[ch] files. This will not affect jobs coming via lpr on the local machine. Reviewed by: freebsd-print@bostonradio.org & freebsd-audit MFC after: 16 days
* Replace a call to 'alloca', thus avoiding an error when compiling ongad2001-07-151-8/+14
| | | | | | | freebsd/alpha with -ansi (and on some non-fbsd platforms). This change can only affect the access checking of 'lpr -r'. MFC after: 1 week
* Get rid of one compile-time warning by changing an 'int' to a 'size_t'.gad2001-07-151-6/+10
| | | | MFC after: 1 week
* Get lpr/pac.c to compile without warnings with BDECFLAGSgad2001-07-151-15/+15
| | | | MFC after: 1 week
* Replace three subtly-wrong calls to strncpy with calls to strlcpy, andgad2001-07-152-15/+13
| | | | | | use (size_t) in a few places to avoid compile-time warnings on alpha. MFC after: 1 week
* Fix most of the warnings generated by compiling lpr with -Wnon-const-format,gad2001-07-157-21/+27
| | | | | | | | | often by just telling gcc that some internal routine is "__printflike" (work done by Kris Kennaway <kris@FreeBSD.org>). Also fix the new warnings which show up once gcc starts checking the "printf-like parameters" passed to those routines. MFC after: 1 week
* Change signal-handling to reset SIGCHLD to SIGDFLT instead of SIG_IGN.gad2001-07-142-6/+40
| | | | | | | | | | This fixes a problem with using print filters (if=, of=, etc) that showed up in -current around June 20th. That problem initially reported by Georg-W Koltermann <gwk@sgi.com>, while most of the investigation that led to this fix was done by Anton Berezin <tobez@FreeBSD.org>. Reviewed by: freebsd-print@bostonradio.org MFC after: 1 week
* mdoc(7) police: removed HISTORY info from the .Os call.ru2001-07-107-7/+7
|
* Fix the type of the NULL arg to execl()brian2001-07-091-3/+4
| | | | Idea from: Theo de Raadt <deraadt@openbsd.org>
* mdoc(7) police: removed hard sentence breaks, use new .Brq macro.ru2001-07-051-54/+27
|
* Make 'lpc clean' somewhat safer. Add an 'lpc tclean' command, which allowsgad2001-06-256-47/+351
| | | | | | | | | | | | | | | | | | | one to see what files would be removed *if* an 'lpc clean' is done. 'tclean' will remove no files, and is therefore not a privileged command. Also, both 'lpc clean' and 'lpc tclean' will now look for 'core' files in spool directories (but not remove them). They also print out an extra line of info when a datafile to be removed is a symlink (from 'lpr -s'), saying what file it is a symlink to. The 'lpc clean' commands also now print out a summary line saying how many queues were checked, how many files were removed (or "would be" removed, for tclean), and how much disk space is involved. For the benefit of those who have many print queues, 'lpc clean all' will only print out the names of print queues where some "interesting" files were found, instead of printing out a header-line for every queue in your printcap file. Reviewed by: freebsd-print@bostonradio.org freebsd-audit@FreeBSD.org MFC after: 2 weeks
* Add two new options for lpd: -c will log all connection-errors to syslog,gad2001-06-252-32/+168
| | | | | | | | | | | | | | | while -w allows connection from non-reserved ports. Also improves the helpfulness of various connection-error messages. The changes for IPv6 added back in the reserved-port check which was mistakenly dropped from lpd in 1997 (copying a change from openbsd). It is best to have that check in place, but the check breaks lpr's from some implementations of lpr/lpd for Windows. The -w option is for those admins who need to accept jobs from non-reserved ports, the -c option is for admins who would like a print-server machine to log all failed connection-attempts to syslog. Reviewed by: freebsd-audit@FreeBSD.org freebsd-print@bostonradio.org MFC after: 2 weeks
* Get rid of a trigraph ("??>") mistakenly put in an error message.gad2001-06-161-1/+1
| | | | | | One less warning to annoy me... MFC after: 1 week
* *** empty log message ***gad2001-06-151-19/+15
|
* Rename a few global variables which hold hostname-related values to begad2001-06-1512-69/+90
| | | | | | | | | | | | | | | more sensible/understandable. 'from'->'from_host' 'host'->'local_host' 'fromb'->'frombuf' 'fromhost'->'origin_host' and a local-variable named 'host'->'hostbuf'. This fixes some compile-time warnings about local variables shadowing global variables. Other than renaming variables, the only actual code changes are to call strlcpy() instead of strncpy() when setting those (renamed) variables, and that 'from_ip' is now a strdup()-created buffer instead of being a static buffer compiled in as 1025 bytes. Reviewed by: freebsd-print@bostonradio.org (an earlier version) MFC after: 1 week
* Rename global variable 'name' to 'progname', thus fixing a number ofgad2001-06-157-27/+30
| | | | | | | | warnings which come up for various routines that have a parameter which is also called 'name'. Reviewed by: freebsd-print@bostonradio.org MFC after: 1 week
* Fix about 90-100 warnings one gets when trying to compile lpr&friendsgad2001-06-1222-568/+405
| | | | | | | | | | | | with BDECFLAGS on, mainly by adding 'const' to parameters in a number of routine declarations. While I'm at it, ANSI-fy all of the routine declarations. The resulting object code is exactly the same after this update as before it, with the exception of one unavoidable change to lpd.o on freebsd/alpha. Also added $FreeBSD$ line to lpc/extern.h lpc/lpc.h lptest/lptest.c Reviewed by: /sbin/md5, and no feedback from freebsd-audit
* Correct cross-references:sobomax2001-06-051-1/+1
| | | | | | | | setsockopt.3 --> setsockopt.2 syslog.8 --> syslogd.8 tcpdump.8 --> tcpdump.1 MFC after: 1 week
* mdoc(7) police: properly use a -diag list in the DIAGNOSTICS section.dd2001-04-131-4/+4
| | | | Reviewed by: ru
* beforeinstall -> SCRIPTS.ru2001-04-071-4/+2
|
* Make sure the euid is restored in an obscure error situation.gad2001-04-061-3/+4
| | | | Submitted by: J Wunsch <j@ida.interface-business.de> in freebsd-audit
* - Backout botched attempt to introduce MANSECT feature.ru2001-03-269-7/+7
| | | | - MAN[1-9] -> MAN.
OpenPOWER on IntegriCloud