summaryrefslogtreecommitdiffstats
path: root/usr.sbin/lpr/lpd/recvjob.c
Commit message (Collapse)AuthorAgeFilesLines
* Remove the advertising clause from UCB copyrighted files in usr.sbin. Thisjoel2010-12-111-4/+0
| | | | | is in accordance with the information provided at ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
* use bigger local variable to calculate free spaceticso2008-09-011-1/+1
| | | | int overflows at 1T free space
* Use sizeof() for calculating the buffer size instead of hard-coded values.kevlo2007-03-061-1/+1
|
* Minimal update to make it easier to increase the buffer-size lpd usesgad2003-08-211-4/+9
| | | | | | | | | | when reading/writing spool files. I intend to do a more elaborate version, but I want to get this much in before 4.9-release. As written, this results in no change to the object code. Submitted by: John-Mark Gurney Reviewed by: /sbin/md5 MFC after: 4 days
* Use STDIN_FILENO, STDOUT_FILENO, and STDERR_FILENO in a few moregad2003-08-131-1/+1
| | | | | | | | places (replacing constants 0, 1 & 2). Noticed by: Reviewed by: md5 MFC after: 4 days
* Get the 'sccsid' lines even closer to correct style(9) form. Thegad2003-07-141-0/+2
| | | | | | | '#ifdef lint/#endif' around the lines should not have been removed. Reviewed by: noticed by bde MFC after: 15 days
* More changes to use __FBSDID() for setting rcsids, and fix thegad2003-07-141-4/+3
| | | | | | | | format of 'sccsid' lines so they consistently match style(9) guidelines. Inspired by recent update to lpd.c by charnier. Reviewed by: discussed on cvs-src & with bde and obrien MFC after: 15 days
* Assume __STDC__, remove non-__STDC__ code.alfred2002-05-281-14/+0
|
* Move the checks for '/' a little sooner in the code which receives filesgad2001-12-051-8/+8
| | | | | | | | | | | for a remote print job. This change comes from OpenBSD (who got it from Sebastian Krahmer of SuSE). In OpenBSD this avoids a tiny theoretical security issue, but that security issue does not exist in FreeBSD's lpr due to the changes which added 'ctl_renametf()' just before 4.4-release. This change is still worth doing in our version, but it isn't fixing a security issue. MFC after: 4 days
* Get rid of some compile-time warnings by defining (or casting) variablesgad2001-07-231-19/+20
| | | | | | as size_t where appropriate. MFC after: 1 week
* Replace calls to strncpy with calls to strlcpy, and remove the extra stepgad2001-07-221-6/+4
| | | | | | needed to ensure that the result is null-terminated when using strncpy(). MFC after: 8 days
* Change a few read & write calls to use 'STDOUT_FILENO' instead of '1'.gad2001-07-221-6/+6
| | | | | | Submitted by: David Hill <david@phobia.ms> Reviewed by: freebsd-audit (a little) MFC after: 1 week
* Change lpd to perform sanity and safety checks on control files as itgad2001-07-151-4/+7
| | | | | | | | | | | | receives them from other hosts. This is meant to protect from both nefarious users (which maybe broke into some remote host that we accept print jobs from), and broken implementations of lpr on other platforms. This is done by changing recvjob.c to call the new ctl_renametf() routine in the new common_source/ctlinfo.[ch] files. This will not affect jobs coming via lpr on the local machine. Reviewed by: freebsd-print@bostonradio.org & freebsd-audit MFC after: 16 days
* Fix most of the warnings generated by compiling lpr with -Wnon-const-format,gad2001-07-151-6/+10
| | | | | | | | | often by just telling gcc that some internal routine is "__printflike" (work done by Kris Kennaway <kris@FreeBSD.org>). Also fix the new warnings which show up once gcc starts checking the "printf-like parameters" passed to those routines. MFC after: 1 week
* Rename a few global variables which hold hostname-related values to begad2001-06-151-3/+4
| | | | | | | | | | | | | | | more sensible/understandable. 'from'->'from_host' 'host'->'local_host' 'fromb'->'frombuf' 'fromhost'->'origin_host' and a local-variable named 'host'->'hostbuf'. This fixes some compile-time warnings about local variables shadowing global variables. Other than renaming variables, the only actual code changes are to call strlcpy() instead of strncpy() when setting those (renamed) variables, and that 'from_ip' is now a strdup()-created buffer instead of being a static buffer compiled in as 1025 bytes. Reviewed by: freebsd-print@bostonradio.org (an earlier version) MFC after: 1 week
* Fix about 90-100 warnings one gets when trying to compile lpr&friendsgad2001-06-121-23/+15
| | | | | | | | | | | | with BDECFLAGS on, mainly by adding 'const' to parameters in a number of routine declarations. While I'm at it, ANSI-fy all of the routine declarations. The resulting object code is exactly the same after this update as before it, with the exception of one unavoidable change to lpd.o on freebsd/alpha. Also added $FreeBSD$ line to lpc/extern.h lpc/lpc.h lptest/lptest.c Reviewed by: /sbin/md5, and no feedback from freebsd-audit
* Minor style improvements.gad2000-11-141-5/+5
|
* Cosmetic improvements to a few recvjob-related error messages.gad2000-11-061-18/+35
|
* In the error-message routine for receiving a job, move the "cleanup" to begad2000-11-051-2/+17
| | | | | | | after the error message is printed, because the error message may refer to variables the "cleanup" routine will zero out. PR: 21007
* Implement new printcap options of sr= (aka stat.recv) and sr= (aka stat.send)gad2000-11-021-4/+14
| | | | | | | | in lpd. Stat.recv is useful on a printserver, as something of a network performance-monitoring tool. Stat.send is a minimal accounting record of sorts for jobs going to tcp/ip based printers. Reviewed by: freebsd-print@bostonradio.org
* $Id$ -> $FreeBSD$peter1999-08-281-1/+1
|
* Properly initialize the printer struct.wollman1998-01-201-1/+2
| | | | PR: bin/5519
* Mega lpd/lpd upgrade, part I:wollman1997-12-021-25/+28
| | | | | | | | | | | | | | | - Get rid of a lot of the static variables which were shared by many routines and programs in the suite. - Create an abstract interface to the printcap database, so that other retrieval and iteration mechanisms could be developed (e.g., YP, Hesiod, or automatic retrieval from a trusted server). - Give each capability a human-readable name in addition to the historic two-character one. - Otherwise generally clean up a lot of dark corners. Many still remain. - When submitting jobs, use the official login name record (from getlogin()) if there is one, rather than reverse-mapping the uid. More to come...
* Be more paranoid about unlinking files. From mhpower@MIT.EDU by way ofimp1997-10-061-4/+6
| | | | | | | Theo de Raadt. Likely 2.2.5R candidate. Obtained from: OpenBSD
* Use err(3). Add usage(). Various fixes in man pages.charnier1997-09-241-4/+8
|
* Two minor, pedantic fixes from bde for my last pedantic fixes, plusimp1997-07-291-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the following from recent OpenBSD changes. These changes (and all I've made) should be merged back into 2.2 when they are vetted in -current. common.c: OpenBSD 1.7: mickey: #if __STDC__ --> #ifdef __STDC__ displayq.c: OpenBSD 1.8: deraadt: 1 byte oflows; millert rmjob.c: OpenBSD 1.8: deraadt: 1 byte oflows; millert cmds.c: OpenBSD 1.9: grr: restore traditional "all" keyword option - see lpc(8) [[ This makes lpc status all work again -- imp ]] printjob.c: OpenBSD 1.17: deraadt: use sendmail -t OpenBSD 1.16: mickey: #if __STDC__ --> #ifdef __STDC__ OpenBSD 1.15: deraadt: 1 byte oflow; Don.Lewis@tsc.tdk.com recvjob.c: OpenBSD 1.11: mickey: #if __STDC__ --> #ifdef __STDC__ lpr.c: OpenBSD 1.19: mickey: #if __STDC__ --> #ifdef __STDC__ Obtained from: OpenBSD
* Fix boatloads of buffer overflows from the OpenBSD tree.imp1997-07-291-10/+17
| | | | | Be pedantic about always using sizeof(blah) vs sizeof (blah) or sizeof blah. Obtained from:OpenBSD
* index -> strchr and rindex -> strrchr to reduce the number of gratuitousimp1997-07-231-1/+1
| | | | | | diffes with NetBSD/OpenBSD. These changes seem to predate the NetBSD/OpenBSD split, so it is hard to give proper credit for them. Obtained from: OpenBSD.
* Increase size of tmp hostname buffer.phk1997-07-161-2/+2
| | | | | | PR: 3889 Reviewed by: phk Submitted by: Yujiro MIYATA <miyata@bioele.nuee.nagoya-u.ac.jp>
* lpc/cmds.c:imp1996-10-271-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From NetBSD via OpenBSD to fix NetBSD PR #506 More descriptive message for printer status (OpenBSD: 1.2) Various warnings cleaned up (OpenBSD: 1.4) lpc/lpc.c: Various warnings cleaned up (OpenBSD: 1.3) lpd/lpd.c: Remove trailing blank lines (OpenBSD: 1.2) Potential umask problem with creating /dev/printer (OpenBSD: 1.4 and 1.5) Ftp bounce attack (untested on FreeBSD) (OpenBSD: 1.6, 1.8, 1.9) Fencepost in strncpy (OpenBSD: 1.6) lpd/printjob.c: Fix from freebsd for waiting for an exiting filter, that appears not in the FreeBSD CVS tree. (OpenBSD: 1.6) lpd/recvjob.c: Buffer overflow protection: use strncpy rather than strcpy. (OpenBSD: 1.3) lpr/lpr.c: NetBSD change of return type for main() (OpenBSD: 1.2) Restrict time running as root (OpenBSD: 1.7) Use getcwd rather than getwd (from NetBSD) Use snprintf rather than sprintf (OpenBSD: 1.8) Minor tweak to end of loop and buffer overflow sanity. card() overflow already in FreeBSD (OpenBSD: 1.9) lptest/lptest.c: void -> int return type of main, from NetBSD via OpenBSD (OpenBSD: 1.2) pac/pac.c: void -> int return type of main, from NetBSD via OpenBSD (OpenBSD: 1.3) Obtained from: OpenBSD
* Cleanup.joerg1996-05-091-1/+0
| | | | | | | | | The removed files are no longer needed, they are actually labelled as ``Use only if you are not 4.4BSD''. (Yeah, the ol' crufty printcap.c is really gone!) Properly declare all external objects in files ending in .h, as opposed to embed them into files ending in .c.
* Pull a bunch of fixes from the 4.4BSD-Lite2 branch. It's reallyjoerg1996-05-051-2/+2
| | | | | | | | | | | | surprising how many trivial errors there have been... :-) Some more cleanup is needed, but i'd like to separate the Lite2 changes from other work, that's why this goes into a different commit. People with serial printers should see whether i have broken the stty- style printcap options (i hope not). Inspired by: Sergey Shkonda <serg@bcs1.bcs.zaporizhzhe.ua>
* Remove trailing whitespace.rgrimes1995-05-301-1/+1
|
* BSD 4.4 Lite usr.sbin Sourcesrgrimes1994-05-261-0/+358
OpenPOWER on IntegriCloud