summaryrefslogtreecommitdiffstats
path: root/usr.sbin/lpr/common_source
Commit message (Collapse)AuthorAgeFilesLines
* Fix a few more minor compile-time warnings, mainly by using size_t wheregad2001-07-231-10/+15
| | | | | | | appropriate, and using '("%lu", (unsigned long)asizeval)' when printing something of type size_t. MFC after: 1 week
* Replace calls to strncpy with calls to strlcpy, and remove the extra stepgad2001-07-221-6/+3
| | | | | | needed to ensure that the result is null-terminated when using strncpy(). MFC after: 8 days
* Perform a major cleanup of the usr.sbin Makefiles.obrien2001-07-201-3/+4
| | | | | These are not perfectly in agreement with each other style-wise, but they are orders of orders of magnitude more consistent style-wise than before.
* Change lpd to perform sanity and safety checks on control files as itgad2001-07-153-2/+924
| | | | | | | | | | | | receives them from other hosts. This is meant to protect from both nefarious users (which maybe broke into some remote host that we accept print jobs from), and broken implementations of lpr on other platforms. This is done by changing recvjob.c to call the new ctl_renametf() routine in the new common_source/ctlinfo.[ch] files. This will not affect jobs coming via lpr on the local machine. Reviewed by: freebsd-print@bostonradio.org & freebsd-audit MFC after: 16 days
* Replace three subtly-wrong calls to strncpy with calls to strlcpy, andgad2001-07-152-15/+13
| | | | | | use (size_t) in a few places to avoid compile-time warnings on alpha. MFC after: 1 week
* Fix most of the warnings generated by compiling lpr with -Wnon-const-format,gad2001-07-152-4/+5
| | | | | | | | | often by just telling gcc that some internal routine is "__printflike" (work done by Kris Kennaway <kris@FreeBSD.org>). Also fix the new warnings which show up once gcc starts checking the "printf-like parameters" passed to those routines. MFC after: 1 week
* Rename a few global variables which hold hostname-related values to begad2001-06-155-27/+49
| | | | | | | | | | | | | | | more sensible/understandable. 'from'->'from_host' 'host'->'local_host' 'fromb'->'frombuf' 'fromhost'->'origin_host' and a local-variable named 'host'->'hostbuf'. This fixes some compile-time warnings about local variables shadowing global variables. Other than renaming variables, the only actual code changes are to call strlcpy() instead of strncpy() when setting those (renamed) variables, and that 'from_ip' is now a strdup()-created buffer instead of being a static buffer compiled in as 1025 bytes. Reviewed by: freebsd-print@bostonradio.org (an earlier version) MFC after: 1 week
* Rename global variable 'name' to 'progname', thus fixing a number ofgad2001-06-152-3/+3
| | | | | | | | warnings which come up for various routines that have a parameter which is also called 'name'. Reviewed by: freebsd-print@bostonradio.org MFC after: 1 week
* Fix about 90-100 warnings one gets when trying to compile lpr&friendsgad2001-06-127-173/+125
| | | | | | | | | | | | with BDECFLAGS on, mainly by adding 'const' to parameters in a number of routine declarations. While I'm at it, ANSI-fy all of the routine declarations. The resulting object code is exactly the same after this update as before it, with the exception of one unavoidable change to lpd.o on freebsd/alpha. Also added $FreeBSD$ line to lpc/extern.h lpc/lpc.h lptest/lptest.c Reviewed by: /sbin/md5, and no feedback from freebsd-audit
* Make sure the euid is restored in an obscure error situation.gad2001-04-061-3/+4
| | | | Submitted by: J Wunsch <j@ida.interface-business.de> in freebsd-audit
* Fix "lprm -" (remove all jobs) processing for remote printer queues.gad2001-03-121-10/+17
| | | | PR: bin/25544
* Use macro API to <sys/queue.h>phk2000-12-301-2/+2
| | | | | Submitted by: "Jason" <jsmethers@pdq.net> Reviewed by: /sbin/md5
* IPv6 support for lpr.ume2000-12-162-80/+111
| | | | | Reviewed by: freebsd-current (no objection) Obtained from: KAME
* Reset the seteuid in a few obscure error situations.gad2000-11-151-1/+4
|
* Just some style-related improvements.gad2000-11-151-24/+32
|
* Cosmetic change of a structure name.gad2000-11-063-24/+24
| | | | | | | Turn 'struct queue { q_time, q_name }' (loosely-speaking) into 'struct jobqueue { job_time, job_cfname }' Reviewed by: GAWollman
* Fix 'lprm' processing so is more likely to work correctly when dealinggad2000-11-051-1/+1
| | | | | | | with long (>32 character) hostnames. PR: 14978 Submitted by: Tatsuya Kudoh <cdr@cosmonet.org>
* Implement new printcap options of sr= (aka stat.recv) and sr= (aka stat.send)gad2000-11-024-3/+325
| | | | | | | | in lpd. Stat.recv is useful on a printserver, as something of a network performance-monitoring tool. Stat.send is a minimal accounting record of sorts for jobs going to tcp/ip based printers. Reviewed by: freebsd-print@bostonradio.org
* Make the standard 'lpq' output a little more informative when listing jobsgad2000-10-311-12/+39
| | | | | | | which have long names. Instead of just listing '...', try to list some reasonable subset of the name (with a "..." to indicate something missing). Reviewed by: freebsd-print@bostonradio.org (only a little review)
* Fix 'lpq' so it can correctly display jobs which come from hosts usinggad2000-10-311-9/+44
| | | | | | 'lprNG' (which writes control-lines in a different order than our lpr). Reviewed by: freebsd-print@bostonradio.org
* Fix cosmetic error in rmjob message.wollman2000-09-271-2/+0
| | | | PR: 21006
* Back out the previous change to the queue(3) interface.jake2000-05-261-6/+6
| | | | | | It was not discussed and should probably not happen. Requested by: msmith and others
* Change the way that the queue(3) structures are declared; don't assume thatjake2000-05-231-6/+6
| | | | | | | | the type argument to *_HEAD and *_ENTRY is a struct. Suggested by: phk Reviewed by: phk Approved by: mdodd
* This appears to have been repo-copied to lpd a while ago and neverimp2000-05-091-375/+0
| | | | | deleted here. Diff shows there is only one change to this file, which matches the repo histories.
* Print files submitted at the same instant in deterministic order.wollman2000-05-031-5/+20
| | | | | PR: 18361 Submitted by: Garance A Drosehn <gad@freefour.acs.rpi.edu>
* $Id$ -> $FreeBSD$peter1999-08-2810-10/+10
|
* lpd tries to be clever and checks if RM == my_hostname.jkh1999-04-273-3/+25
| | | | | | | | | However, it doesn't check if the remote printer name it is sending it to is the same as the local printer name, and so chokes 'cos "laser" is not a real printer. PR: 7081 Submitted by: David Malone <dwmalone@maths.tcd.ie>
* Fix additional warnings. Remove -Werror, since some people have complainedwollman1998-09-112-5/+4
| | | | | | | about it. PR: 7886 Submitted by: Stefan Eggers <seggers@semyam.dinoco.de> (partially)
* Remove -Werror from CFLAGS on i386 because with -nostdinc gcc spitsjb1998-06-111-4/+1
| | | | | warnings from unused static inline functions in headers if you happen to set CFLAGS without -O.
* The printf type checking in gcc wants %qd to be a long long, so addjb1998-05-131-2/+2
| | | | a cast in case off_t is not a long long (as on alpha).
* Make -Werror i386 specific because -nostinc on alpha spits warningsjb1998-05-131-2/+5
| | | | for unused static inline functions in header files.
* Fix top-of-form bogon.wollman1997-12-271-2/+2
|
* Mega lpd/lpd upgrade, part I:wollman1997-12-0211-394/+1210
| | | | | | | | | | | | | | | - Get rid of a lot of the static variables which were shared by many routines and programs in the suite. - Create an abstract interface to the printcap database, so that other retrieval and iteration mechanisms could be developed (e.g., YP, Hesiod, or automatic retrieval from a trusted server). - Give each capability a human-readable name in addition to the historic two-character one. - Otherwise generally clean up a lot of dark corners. Many still remain. - When submitting jobs, use the official login name record (from getlogin()) if there is one, rather than reverse-mapping the uid. More to come...
* Argl! Who's got the pointy hat these days? Hand it over to me, ASAP!joerg1997-11-071-0/+1
| | | | | When setting an alarm that didn't trigger, i gotta clear it again before going on. Hmpf!
* One could be surprised how much bugs can still be found here...joerg1997-10-151-2/+3
| | | | | | | | | | | | Properlay clean the global RM variable if cgetstr() failed for it. Otherwise, a connection attempt to a remote machine was made (and a bogus result code printed) if a local printer followed a remote one in printcap, and you did a `lpq -a', since checkremote() falsely assumed the printer to be a remote one. While i was at it, removed a gratuituous newline printed in front of the remote machine's name, thus making the output more consistent (and better machine-parseable) now.
* Improve my hack from rev 1.6 of displayq.c, and make the TCPjoerg1997-10-145-2/+20
| | | | | | | | connection timeout controllable by a new printcap(5) capability named `ct' (connectiom timeout), defaulting to 120 seconds (which is the default TCP connection timeout). Would anybody see a problem with merging all this into RELENG_2_2?
* Be more paranoid about unlinking files. From mhpower@MIT.EDU by way ofimp1997-10-061-4/+6
| | | | | | | Theo de Raadt. Likely 2.2.5R candidate. Obtained from: OpenBSD
* Use err(3). Add usage(). Various fixes in man pages.charnier1997-09-243-18/+21
|
* common_source: staticize private version of warn() so to not conflictjoerg1997-08-232-2/+2
| | | | | | | | | with libc's version. lpd: use getopt(3), err(3), add usage(), allow specification of a port # on the command line as the documentation suggested for more than 10 years. PR: docs/3290
* Two minor, pedantic fixes from bde for my last pedantic fixes, plusimp1997-07-295-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the following from recent OpenBSD changes. These changes (and all I've made) should be merged back into 2.2 when they are vetted in -current. common.c: OpenBSD 1.7: mickey: #if __STDC__ --> #ifdef __STDC__ displayq.c: OpenBSD 1.8: deraadt: 1 byte oflows; millert rmjob.c: OpenBSD 1.8: deraadt: 1 byte oflows; millert cmds.c: OpenBSD 1.9: grr: restore traditional "all" keyword option - see lpc(8) [[ This makes lpc status all work again -- imp ]] printjob.c: OpenBSD 1.17: deraadt: use sendmail -t OpenBSD 1.16: mickey: #if __STDC__ --> #ifdef __STDC__ OpenBSD 1.15: deraadt: 1 byte oflow; Don.Lewis@tsc.tdk.com recvjob.c: OpenBSD 1.11: mickey: #if __STDC__ --> #ifdef __STDC__ lpr.c: OpenBSD 1.19: mickey: #if __STDC__ --> #ifdef __STDC__ Obtained from: OpenBSD
* Fix boatloads of buffer overflows from the OpenBSD tree.imp1997-07-294-16/+23
| | | | | Be pedantic about always using sizeof(blah) vs sizeof (blah) or sizeof blah. Obtained from:OpenBSD
* index -> strchr and rindex -> strrchr to reduce the number of gratuitousimp1997-07-231-1/+1
| | | | | | diffes with NetBSD/OpenBSD. These changes seem to predate the NetBSD/OpenBSD split, so it is hard to give proper credit for them. Obtained from: OpenBSD.
* Use setuid/seteuid around dangerous operations. Also a few bufferimp1997-07-234-12/+78
| | | | | | | | | | | | overflow patches that were "near" to where these operations are taking place. The buffer overflows are from OpenBSD. The setuid/seteuid patches are from NetBSD by way of OpenBSD (they changed them a little), at least from my read of the tree. This is the first of a series of OpenBSD lpr/et al merges. It (and them) should be merged back into 2.2 and/or 2.1 (if requested) branches when they have been shaken out in -current. Obtained from: OpenBSD
* Add code to make sure that we don't overflow the buffer that we copyimp1997-07-181-1/+4
| | | | | | | | | the hostname into. In theory the bind library should do this, but in practice the limites between system defines and bind defines make an attack using this vector possible. These patches have been in use on my systems for three months now, so I am fairly confident about them. I plan on commiting this to 2.2 and 2.1 in the near future, as well as many other patches of this nature.
* Fix a problem where remote files could be removed by exploiting raceimp1997-07-181-0/+2
| | | | | conditions similar to those reported in CERT's CA-91:10a advisory. Obtained from: Hiroshi NAKANO <nakano@rins.ryukoku.ac.jp> by way of CERT.
* Increase size of tmp hostname buffer.phk1997-07-161-2/+2
| | | | | | PR: 3889 Reviewed by: phk Submitted by: Yujiro MIYATA <miyata@bioele.nuee.nagoya-u.ac.jp>
* Imply a 10-second connection timeout when querying remote queues, tojoerg1997-06-231-0/+13
| | | | | prevent lpq from hanging indefinately (well, 10 minutes are for sure counting as `indefinately' in this case).
* Buffer overflow from OpenBSD:imp1997-02-091-5/+8
| | | | | | | | | | Rev 1.4 deraadt: (partial from full commit, other files not done yet) proactive bounds checking; help from millert Rev 1.5 millert: Possible buf oflow. Plus minor style nits to keep the style police happy (I hope) Obtained from: OpenBSD
* lpc/cmds.c:imp1996-10-271-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From NetBSD via OpenBSD to fix NetBSD PR #506 More descriptive message for printer status (OpenBSD: 1.2) Various warnings cleaned up (OpenBSD: 1.4) lpc/lpc.c: Various warnings cleaned up (OpenBSD: 1.3) lpd/lpd.c: Remove trailing blank lines (OpenBSD: 1.2) Potential umask problem with creating /dev/printer (OpenBSD: 1.4 and 1.5) Ftp bounce attack (untested on FreeBSD) (OpenBSD: 1.6, 1.8, 1.9) Fencepost in strncpy (OpenBSD: 1.6) lpd/printjob.c: Fix from freebsd for waiting for an exiting filter, that appears not in the FreeBSD CVS tree. (OpenBSD: 1.6) lpd/recvjob.c: Buffer overflow protection: use strncpy rather than strcpy. (OpenBSD: 1.3) lpr/lpr.c: NetBSD change of return type for main() (OpenBSD: 1.2) Restrict time running as root (OpenBSD: 1.7) Use getcwd rather than getwd (from NetBSD) Use snprintf rather than sprintf (OpenBSD: 1.8) Minor tweak to end of loop and buffer overflow sanity. card() overflow already in FreeBSD (OpenBSD: 1.9) lptest/lptest.c: void -> int return type of main, from NetBSD via OpenBSD (OpenBSD: 1.2) pac/pac.c: void -> int return type of main, from NetBSD via OpenBSD (OpenBSD: 1.3) Obtained from: OpenBSD
* Cleanup.joerg1996-05-098-1032/+9
| | | | | | | | | The removed files are no longer needed, they are actually labelled as ``Use only if you are not 4.4BSD''. (Yeah, the ol' crufty printcap.c is really gone!) Properly declare all external objects in files ending in .h, as opposed to embed them into files ending in .c.
OpenPOWER on IntegriCloud