| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
| |
Fix iscsictl(8) and ctld(8) to correctly handle Windows newlines
(CRLF) in iscsi.conf and ctl.conf.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Keep the token list sorted.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to optionally use semicolon to separate statements.
This makes it possible to format stuff like this:
target xxx {
lun 0 { path /foo/bar; size 4G; }
}
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Simplify code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.
|
|
|
|
|
|
| |
Fix build after previous commit. While here, improve error messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Remove the distinction between strings and numbers from ctld(8) yacc parser.
This fixes problems with passing strings that look like numbers to clauses
that expect strings; previously it caused syntax errors and had to be worked
by user, using quotes. The workaround introduced in r267833 is no longer
neccessary.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Improve ctld.conf example.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Fix ctl.conf example to use proper paths to ZVOLs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Comment out parts about iSER; it's not implemented.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the initiator-name and initiator-portal checks a little nicer.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Tidy up the login code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.
Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.
Relnotes: Yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
| |
Make both iSCSI initiator and target support base64 encoded CHAP data.
While all tested initiators and targets use hex-encoded CHAP data, RFC also
allows base64 encoding there, and Microsoft certificaition tool uses it.
|
|
|
|
|
|
| |
Clean up (refactor) discovery a little; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove misleading statement. Bump date.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove spurious empty line.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix ctld(8) to not show the "auth-group <name> not assigned to any target"
warning for auth-groups assigned to a portal-group.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Whitespace fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use keys_add_int() where appropriate. No functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Untangle iSCSI authentication code by splitting off the CHAP
implementation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Make ctld start even if some LUNs are unable to open backing storage.
Such LUNs will be visible to initiators, but return "not ready" status
on media access commands. If backing storage become available later,
`ctladm modify ...` or `service ctld reload` can trigger its reopen.
|
|
|
|
|
|
|
|
|
| |
on configuration reload also if that size was not specified in the new
configuration.
Previously it happened only if size was explicitly changed in config.
Approved by: re (delphij)
|
|
|
|
|
|
|
| |
Fix two small nits in ctl.conf(5).
Approved by: re (glebius)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Improve markup and language throughout the ctl.conf man page
MFC r271543:
Add the new iscsi(4) man page
Cross reference it from iscsid(8) and iscsictl(8)
Approved by: re (gjb), bcr (mentor)
|
|
|
|
|
|
|
|
|
|
| |
Fix ctld(8) to not forget to send TargetPortalGroupTag and TargetAlias
when the initiator skips security negotiation. This fixes interoperability
with Xtend SAN initiator.
PR: 193021
Approved by: re (marius)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Avoid ctld(8) crash on getaddrinfo(3) failure.
Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Turn two errors, which are possible to trigger only by bugs,
into assertions.
Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix typo.
Approved by: re (marius)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Add missing libraries to DPADD; sort DPADD so DPADD and LDADD match up
This fixes "make checkdpadd"
Approved by: jmmv (mentor)
Phabric: D630
PR: 192765
|
|
|
|
|
|
| |
Make the iSCSI stack use __FBSDID() properly.
Sponsored by: The FreeBSD Foundation
|
|
|
|
| |
Add netmasks support to initiator-portal option.
|
|
|
|
|
| |
Correct spelling errors in ctld.8. While here, correct similar errors
in ctl.conf.5 and fix a couple of contractions.
|
|
|
|
| |
Fix ctld crash on startup if target alias is not set.
|
|
|
|
|
|
|
|
| |
Close race in r268291 between port destruction, delayed by sessions
teardown, and new port creation during `service ctld restart`.
Close it by returning iSCSI port internal state, that allows to identify
dying ports, which should not be counted as existing, from really alive.
|
|
|
|
|
|
|
| |
Pass through iSCSI session ISID from LOGIN request to the CTL frontend.
ISID is an important part of initiator transport ID for iSCSI. It is not
used now, but should be to properly implement persistent reservation.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Burry devid port method, which was a gross hack.
Instead make ports provide wanted port and target IDs, and LUNs provide
wanted LUN IDs. After that core Device ID VPD code only had to link all
of them together and add relative port and port group numbers.
LUN ID for iSCSI LUNs no longer created by CTL, but by ctld, and passed
to CTL as "scsiname" LUN option. This makes LUNs to report the same set
of IDs, independently from the port through which it is accessed, as
required by SCSI specifications.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create separate CTL port for every iSCSI target (and maybe portal group).
Having single port for all iSCSI connections makes problematic implementing
some more advanced SCSI functionality in CTL, that require proper ports
enumeration and identification.
This change extends CTL iSCSI API, making ctld daemon to control list of
iSCSI ports in CTL. When new target is defined in config fine, ctld will
create respective port in CTL. When target is removed -- port will be
also removed after all active commands through that port properly aborted.
This change require ctld to be rebuilt to match the kernel.
As a minor side effect, this allows to have iSCSI targets without LUNs.
While that may look odd and not very useful, that is not incorrect.
|
|
|
|
|
|
|
| |
serial_num and device_id fields are not necessarily null-terminated.
Before this it was impossible to use all 16 bytes of serial number, and
client always got serial number NULL-terminated, that is not required.
|
|
|
|
|
| |
On discovery stage add set of TargetAddress keys to reply, reporting to
the client all the portal groups addresses and ports.
|
|
|
|
|
|
|
|
|
|
| |
Fix issues in config parser relating to lun serial numbers.
Without this fix some serial numbers needed to be quoted
to avoid the config parser bailing out.
Submitted by: delphij
Sponsored by: iXsystems
|
|
|
|
|
|
| |
Style fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
English.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
If we fail to create LUN, try again on next configuration reload.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use consistent punctuation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use proper terminology in debug messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Constify.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Properly pass the initiator address when running in proxy mode.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Use socket address from accept(2) instead of retrieving it via
getpeername(2).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rework the way we enable CTL iSCSI port. Previously conf_apply()
needed it to be already enabled, because listening in proxy mode
requires it; however, it's conf_apply() that opens pidfiles,
so it resulted in port being enabled before pidfile was opened.
This was not so bad, but it was also disabled when pidfile couldn't
be opened due to ctld already running; this means that starting
second ctld instance screwed up the first.
Sponsored by: The FreeBSD Foundation
|