| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Style fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
English.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
If we fail to create LUN, try again on next configuration reload.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use consistent punctuation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use proper terminology in debug messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Constify.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Properly pass the initiator address when running in proxy mode.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Use socket address from accept(2) instead of retrieving it via
getpeername(2).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rework the way we enable CTL iSCSI port. Previously conf_apply()
needed it to be already enabled, because listening in proxy mode
requires it; however, it's conf_apply() that opens pidfiles,
so it resulted in port being enabled before pidfile was opened.
This was not so bad, but it was also disabled when pidfile couldn't
be opened due to ctld already running; this means that starting
second ctld instance screwed up the first.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Properly identify target portal when running in proxy mode. While here,
remove CTL_ISCSI_CLOSE, it wasn't used or implemented anyway.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Make it possible for the iSCSI target side to operate in both normal
and ICL_KERNEL_PROXY mode, and fix some bit rot so the latter actually
works again.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Stop treating LUN 0 as mandatory. There is no reason to do that.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the error message more clear.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Empty data segment during Login Phase is rather unlikely, but it's
not, by itself, a protocol error. This fixes interoperability with
OpenBSD initiator.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
The log_whatever() routines don't accept NULL for format strings,
so mark them as __printflike instead of__printf0like.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
| |
So, it turns out SIGCHLD is discarded by default, so we have to set up
a dummy handler to make it interrupt an ioctl(2) or select(2).
This makes those short-lived ctld(8) zombies disappear.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Use new auth-type "deny" instead of using "chap" with no chap entries;
it's cleaner this way, and gives better feedback to the user.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Use "default" as default discovery-auth-group, instead of "no-access".
It doesn't change visible behaviour, as previously auth-group "default"
wasn't redefinable, so by default access was always denied.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Update manual page to match recent auth-group "default" changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Add a new auth-group "default", defaulting to deny, and make it possible
to redefine it. From now on, assigning auth-group to a target is no longer
mandatory.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make it possible to redefine portal-group "default".
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Add auth-type.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Rename a variable, no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Yacc cleanup; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make function ordering slightly more logical; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Implement initiator-name and initiator-portal restrictions.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Daemonize after applying configuration, not before, so that
any problems - including "daemon already running" - are visible
on the terminal and not just in logs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Improve check for duplicated paths. It shows the warning twice for every
path (once for each duplicate found), but it should do for now.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Refactor.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the debug messages during ctld(8) shutdown less confusing.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Show proper configuration file line numbers in error messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make ctld error out on invalid characters in ctl.conf.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Improve error reporting.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Fix handling for empty auth-groups. Without it, ctld child process
would either exit on assertion, or, if assertions are not enabled,
fail to authenticate the target.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Grammar fix.
Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix typos.
Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
| |
Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Coverity CID: 1087993, 1087992
Approved by: re (marius)
Sponsored by: FreeBSD Foundation
|
|
|
|
|
|
| |
Coverity CID: 1011375
Approved by: re (glebius)
Sponsored by: FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix for LIO (Linux target), removing possibility for the target to avoid mutual
CHAP by choosing to skip authentication altogether, and fixing truncated error
messages in iscsictl(8) output. This also fixes several of the problems found
with Coverity.
Note that this change requires world rebuild.
Coverity CID: 1088038, 1087998, 1087990, 1088004, 1088044, 1088041, 1088040
Approved by: re (blanket)
Sponsored by: FreeBSD Foundation
|
|
|
|
|
|
| |
improve module loading in iscsid(8) and ctld(8).
Approved by: re (delphij)
|
|
|
|
| |
Approved by: re (blanket)
|
|
Reviewed by: ken (parts)
Approved by: re (delphij)
Sponsored by: FreeBSD Foundation
|