| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
That is not really an error for the main process.
|
|
|
|
|
|
|
|
|
|
| |
Fix thinko/copypaste error.
When checking the length of the mutual secret password the variable for
the secret password was used by mistake. This resulted in ctld never
warning about the length of the mutual secret being wrong even if it was.
Sponsored by: iXsystems
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update most userspace consumers of capability.h to use capsicum.h instead.
auditdistd is not updated as I will make the change upstream and then do a
vendor import sometime in the next week or two.
Note that a significant fraction does not apply, as FreeBSD 10 doesn't
contain a Capsicumised ping, casperd, libcasper, etc. When these features
are merged, the capsicum.h change will need to be merged with them.
Sponsored by: Google, Inc.
|
| |
|
| |
|
|
|
|
|
| |
While it may have little sense, text and logout requests can be queued.
If they are, they consume cmdsn, so we should increment our conn_cmdsn.
|
|
|
|
| |
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com>
|
|
|
|
| |
Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces new target option "port", that assigns current target
to specified CTL port. On config application ctld(8) will apply LUN mapping
according to target configuration to specified port and bring the port up.
On shutdown cltd(8) will remove the mapping and put the port down.
This change allows to configure both iSCSI and FibreChannel targets in the
same configuration file in alike way.
Kernel side support was added earlier at r278037.
Relnotes: yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
|
|
|
| |
This change allows multiple "portal-group" options to be specified per
target. Each of them may include new optional auth-group name parameter
to override per-target auth parameters for specific portal group.
Kernel side support was added earlier at r278161.
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
| |
While ctld(8) still does not allow multiple portal groups per target
to be configured, kernel should now be able to handle it.
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace iSCSI-specific LUN mapping mechanism with new one, working for any
ports. By default all ports are created without LUN mapping, exposing all
CTL LUNs as before. But, if needed, LUN mapping can be manually set on
per-port basis via ctladm. For its iSCSI ports ctld does it via ioctl(2).
The next step will be to teach ctld to work with FibreChannel ports also.
Respecting additional flexibility of the new mechanism, ctl.conf now allows
alternative syntax for LUN definition. LUNs can now be defined in global
context, and then referenced from targets by unique name, as needed. It
allows same LUN to be exposed several times via multiple targets.
While there, increase limit for LUNs per target in ctld from 256 to 1024.
Some initiators do not support LUNs above 255, but that is not our problem.
Relnotes: yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
|
|
|
| |
For both iSCSI initiator and target increase socket buffer sizes before
establishing connection.
This is a workaround for Chelsio TOE driver, that does not update socket
buffer size in hardware after connection established, and unless that is
done beforehand, kernel code will stuck, attempting to send/receive full
PDU at once.
|
|
|
|
|
|
|
|
|
| |
In conf_apply() remove iSCSI ports from kernel before removing LUNs.
Previous order confused initiators with messages about "removed" LUNs
during simple ctld restart without any real config change. After this
commit initiators only reestablish lost connection, receive "Power on
occurred" UNIT ATTENTION status and continue normal operation.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing error checking for kernel_port_{add,remove}(). Both can fail
for reasons yet unknown; don't make it increment cumulated_error as a kind
of temporary workaround.
MFC r275399:
Fix null pointer dereference.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
While we don't support MCS, hole in received sequence numbers may mean
only PDU loss. While we don't support lost PDU recovery, terminate the
connection to avoid stuck commands.
While there, improve handling of sequence numbers wrap after 2^32 PDUs.
|
|
|
|
|
|
|
| |
Remove the pidfile clause from the ctl.conf example. Why do everyone
just copy/paste this line into their configs, it's beyond me.
Sponsored by: The FreeBSD Foundation
|
| |
|
|
|
|
|
| |
This fixes problem with ctld reload when it is configured to listen on two
portals with same IP, but different ports.
|
|
|
|
|
|
| |
Add HISTORY section to ctld(8).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for sending redirections to iSCSI target.
MFC r274309:
Fix several nits in redirection handling - don't use wrong CSG,
and avoid use-after-free.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
ctld(8) doesn't require -lcam or -lssl; remove those from DPADD and LDADD.
Sponsored by: The FreeBSD Foundation
|
| |
|
|
|
|
|
|
| |
Improve wording in ctl.conf(5).
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix iscsictl(8) and ctld(8) to correctly handle Windows newlines
(CRLF) in iscsi.conf and ctl.conf.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Keep the token list sorted.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to optionally use semicolon to separate statements.
This makes it possible to format stuff like this:
target xxx {
lun 0 { path /foo/bar; size 4G; }
}
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Simplify code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.
|
|
|
|
|
|
| |
Fix build after previous commit. While here, improve error messages.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Remove the distinction between strings and numbers from ctld(8) yacc parser.
This fixes problems with passing strings that look like numbers to clauses
that expect strings; previously it caused syntax errors and had to be worked
by user, using quotes. The workaround introduced in r267833 is no longer
neccessary.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Improve ctld.conf example.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Fix ctl.conf example to use proper paths to ZVOLs.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Comment out parts about iSER; it's not implemented.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Make the initiator-name and initiator-portal checks a little nicer.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Tidy up the login code; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ctld(8) register its iSCSI targets and portals on configured
iSNS servers to allow initiators find them without active discovery.
Fetching of allowed initiators from iSNS is not implemented now, so target
ACLs still should be configured manually.
Relnotes: Yes
Sponsored by: iXsystems, Inc.
|
|
|
|
|
|
|
| |
Make both iSCSI initiator and target support base64 encoded CHAP data.
While all tested initiators and targets use hex-encoded CHAP data, RFC also
allows base64 encoding there, and Microsoft certificaition tool uses it.
|
|
|
|
|
|
| |
Clean up (refactor) discovery a little; no functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove misleading statement. Bump date.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Remove spurious empty line.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Fix ctld(8) to not show the "auth-group <name> not assigned to any target"
warning for auth-groups assigned to a portal-group.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Whitespace fixes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
| |
Use keys_add_int() where appropriate. No functional changes.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
| |
Untangle iSCSI authentication code by splitting off the CHAP
implementation.
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
| |
Make ctld start even if some LUNs are unable to open backing storage.
Such LUNs will be visible to initiators, but return "not ready" status
on media access commands. If backing storage become available later,
`ctladm modify ...` or `service ctld reload` can trigger its reopen.
|
|
|
|
|
|
|
|
|
| |
on configuration reload also if that size was not specified in the new
configuration.
Previously it happened only if size was explicitly changed in config.
Approved by: re (delphij)
|
|
|
|
|
|
|
| |
Fix two small nits in ctl.conf(5).
Approved by: re (glebius)
Sponsored by: The FreeBSD Foundation
|
|
|
|
|
|
|
|
|
|
| |
Improve markup and language throughout the ctl.conf man page
MFC r271543:
Add the new iscsi(4) man page
Cross reference it from iscsid(8) and iscsictl(8)
Approved by: re (gjb), bcr (mentor)
|