| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
entry having stepping value of zero can cause crontab to hang there,
and if the main crontab is being changed in this way, then cron(8)
will keep spining.
Obtained from: OpenBSD [src/usr.sbin/cron/entry.c,v 1.17]
PR: 68683 (my own, but forgot to commit it...)
MFC After: 1 week
|
| |
|
|
|
|
| |
any fake value.
|
|
|
|
|
|
|
|
| |
assignment even if it is not quoted (as advertised by the man page).
This fixes a regression wrt RELENG_4 introduced in rev. 1.11.
Problem noted and patch tested by: CHOI Junho <cjh@kr.FreeBSD.org>
Reviewed by: roberto
|
|
|
|
|
|
|
|
| |
for any reason other than ENOENT (think resource limits). Close allow and
deny files before allowed() returns to stop the user's EDITOR being able to
read them.
Obtained from: OpenBSD (partially)
|
|
|
|
|
|
|
|
|
|
|
| |
line as an environment variable assignment, is broken
and not conformant to its description in the manual page.
I think it is worthwhile to have that fix in 4.6.
PR: bin/38374
Submitted by: Thomas Quinot <thomas@cuivre.fr.eu.org>
MFC after: 2 days
|
| |
|
|
|
|
|
|
|
|
| |
I missed this as part of the fix to the PR below.
PR: 31265
Submitted by: Matthew D. Fuller <fullermd@over-yonder.net>
MFC after: 1 week
|
|
|
|
|
|
|
|
| |
monthly and weekly, respectively. Also fix the @yearly shortcut so
that it doesn't execute daily during January. OpenBSD and NetBSD also
appear to have this bug.
PR: bin/21152
|
|
|
|
|
|
| |
by invalid input in /etc/crontab.
MFC after: 2 days
|
|
|
|
|
| |
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
|
|
|
|
| |
Submitted by: Mark Peek <mark@whistle.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e->cmd. free_entry() now does the right thing with
partially-initialized structures.
load_entry(): Don't call env_free() on e->envp throughout the routine
before jumping to eof; the free_entry() call at that label will take
care of it. The previous behavior resulted in e->envp being free'd
twice (well, the second time would usually result in a crash, but
that's besides the point); once in load_entry(), and once in
free_entry() after the former called the latter. Also note that the
check added to free_entry() (above) doesn't help, since e->envp wasn't
reset to NULL after env_free().
Submitted by: Mark Peek <mark@whistle.com>
|
|
|
|
|
|
|
| |
use free_entry() instead of free() to free a struct _entry.
PR: 28108
Submitted by: Mark Peek <mark@whistle.com>
|
|
|
|
| |
Use _PATH_* where where possible.
|
| |
|
|
|
|
|
|
| |
Rev 1.8 made the type consistently incorrect.
Noted by: Ben Smithurst <ben@scientia.demon.co.uk>
|
|
|
|
|
|
|
|
|
|
|
| |
allocated memory was instead pointed to a static string. A later
free() on the value of the pointer was a possible source of reported
"warning: pointer to wrong page" messages from cron.
Use consistent types in sizeof when malloc'ing memory for the
environment.
PR: kern/12248, bin/11169, bin/9722
|
|
|
|
|
|
|
|
| |
Fix setting of "hour" bitmap when @hourly keyword is specified.
MFC candidate after 4.0-RELEASE.
Problem-found-by: Sheldon Hearn <sheldonh@uunet.co.za>
|
| |
|
|
|
|
|
| |
PR: 9506
Submitted by: Peter Jeremy <peter.jeremy@alcatel.com.au>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use getpwnam before getpwuid since two users with same uids can exists
(affects new login classes code only)
The same fixes as in inetd: by default run `system crontab things' with
daemon login class now, not restrict them to user class breaking
compatibility with old way (so-called nobody limits problem)
Implement user[:group][/login-class] syntax in system crontab
for more flexible control (the same as in inetd)
|
| |
|
|
|
|
|
|
| |
NOPIC is used to not generate a shared library, not NOSHARED.
Make NOSHARED advisory where appropriate.
Remove bogus NOSHARED (kbdio).
|
| |
|
|
|
|
|
|
|
|
| |
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.
|
|
|
|
|
|
|
|
|
|
| |
used by OpenBSD. (Quite frankly, I think it's perfectly reasonable to
use snprintf to copy strings, given that the semantics for strncpy()
are utterly idiotic and there is no POSIX sstrncpy().)
While I'm at it, incorporate some of OpenBSD's bugfixes to cron.
NOT for 2.2
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Submitted by: jkh
|
|
well, expect our two seperate directories for cron and crontab to go away
shortly.
Submitted by: jkh
|