summaryrefslogtreecommitdiffstats
path: root/usr.sbin/bsdconfig/networking
Commit message (Collapse)AuthorAgeFilesLines
* Implement GEOM based media device classification. You'll notice a fewdteske2014-04-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | different things from this commit: + More devices. Devices that were previously ignored are now present. + Faster device scanning. "There is no try, only Do" -- f_device_try() is no longer the basis of device scanning as GEOM provides [nearly] all devices (doesn't provide network devices). + More information available as non-root. Usually you have to be root to do things like taste filesystems, and that limits the amount of information available to non-root users; with GEOM, we see all even running unprivileged as the brunt of information (except for so- called ``dangerously dedicated'' file systems) is represented by the `kern.geom.confxml' sysctl(8) MIB. NB: Only really useful for external scripts that use the API and run as non-root; where this code is used in bsdconfig(8) and bsdinstall(8) you are running as root so can detect even ``dangerously dedicated'' file systems that are not present in GEOM; e.g., no PART class for a DOS filesystem written directly to disk without partition table). + No more use of legacy tools such as diskinfo(8) to get disk capacity or fdisk(8) to see partitions. MFC after: 1 week
* Performance and debugging enhancements:dteske2013-12-0713-83/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Remove UNAME_P=$(...) from startup/misc -- already supplied by common.subr + Use f_getvar instead of $(eval echo \$$var) -- f_getvar is sub-shell free + Add `-e' and `-k var' options to f_eval_catch -- increasing use-cases + Use f_eval_catch to display errors on failure -- reducing duplicated code + Use f_eval_catch when we need output from a command -- improving debugging + Optimize f_isinter of strings.subr for performance -- now sub-shell free + Improve error checking on pidfiles -- using f_eval_catch and f_isinteger + Use $var_to_set arg of f_ifconfig_{inet,netmask} -- eliminate sub-shells + Use f_sprintf instead of $(printf ...) -- consolidate sub-shells + Use $var_to_set arg of f_route_get_default -- eliminate sub-shells + Add f_count to replace $(set -- ...;echo $#) -- eliminate sub-shells + Add f_count_ifs to replace $(IFS=x;set -- ...;echo $#) -- no sub-shells + Replace var="$var${var:+ }..." in loops with var="$var ..." with a follow- up var="${var# }" to trim leading whitespace -- optimize loops + Use $var_to_set arg of f_resolv_conf_nameservers -- eliminate sub-shells + Comments for the f_eval_catch function + Remove a duplicate `local ... desc ...' in f_device_get_all of device.subr + Use $var_to_set arg of f_device_capacity -- eliminate sub-shells + Whitespace fixes in f_dialog_init of dialog.subr + Optimize f_inet_atoi of media/tcpip.subr for performance -- sub-shell free + In several cases, send stderr to /dev/null -- clean up runtime execution + Change f_err of common.subr to go to program stderr not terminal stderr, allowing redirection of output from functions that use f_err + Disable debugging when using f_getvar to get variable argument to f_startup_rcconf_map_expand of startup/rcconf.subr + Use f_replace_all instead of $(echo ... | tr | sed) -- performance + Add a $var_to_set option to f_index_{file,menusel_{command,keyword}} of common.subr -- centralize sub-shells
* Sort messages.dteske2013-11-251-4/+4
|
* Improve network device scanning in the netdev module. First, make it use thedteske2013-11-222-21/+22
| | | | | | | | | | `device.subr' framework (improving performane and reducing sub-shells). Next improve the `device.subr' framework itself. Make use of the `flags' device struct member for network interfaces to indicate if an interface is Active, Wired Ethernet, or 802.11 Wireless. Functions have been added to make checks against the `flags' bit-field quick and efficient. Last, add function for rescanning the network to update the device registers. Remove an unnecessary local (ifn) while we're here (use already provided local `if').
* Remove unused line -- cruft left over from SVN r258360.dteske2013-11-211-1/+0
|
* Quote the interface name for good measure.dteske2013-11-211-6/+7
|
* Whitespace, style, sub-shells, and standardize variable namedteske2013-11-201-26/+20
| | | | (s/interfaces/menu_list/).
* "Tim trailing" -> "Trim trailing"trhodes2013-11-191-1/+1
|
* Introduce centralized [X]dialog(1) exit codes to `dialog.subr' and make-usedteske2013-10-098-40/+39
| | | | | | | | | | throughout the bsdconfig(8) code. While we're here, add an explicit argument to lvalue-seeking invocations of "return" that previously had no argument. Also, consolidate a single instance of double-newline and remove some comments that are no longer required (given increased readability with new exit codes). Approved by: re (glebius)
* Fix typos in the BSD License.dteske2013-07-0715-30/+30
|
* Be consistent with other usr.sbin programs w/respect to the copyrightdteske2013-07-0715-15/+15
| | | | wording ("All rights reserved."); I had the casing wrong on many instances.
* Don't prevent the user from hanging their system by changing networkdteske2013-07-056-17/+16
| | | | | settings while NFS mounts are active; but DO warn them and make the default action to do nothing. (thanks julian)
* Use f_show_msg() instead of f_dialog_msgbox() where appropriate. The maindteske2013-07-052-3/+3
| | | | | | | | | | | | difference between these two functions: Usage: f_show_msg() $format_string [ $format_args ... ] Usage: f_dialog_msgbox() $text [ $hline ] The former lends itself well to displaying the $msg_* i18n text, prompts, etc. While the latter is better for text you do not control (error strings captured as a response from external commands) -- or if you have to control the hline.
* Add the beginnings of the old networking services functionality ofdteske2013-07-052-1/+55
| | | | | | | sysinstall(8). The UI for this will come later while this exposes the functionality to the scripted interface. Tested successfully to first install the pcnfsd package from the `Latest' repository, and second to configure mountd_flags="-n" in rc.conf(5).
* More whitespace.dteske2013-06-2411-32/+33
|
* Alphabetize library includes.dteske2013-06-217-7/+7
|
* Whitespace.dteske2013-06-191-20/+21
|
* Perform some code consolidation and add some additional errordteske2013-06-182-26/+21
| | | | checking/reporting. (similar to SVN revision 251919)
* Whitespace and comments.dteske2013-06-181-4/+2
|
* Improve the INDEX format. Whitespace improvements, format improvements, typodteske2013-06-181-17/+21
| | | | and grammatical fixes.
* Use a case-statement instead of multiple (separate even) if-statements.dteske2013-06-041-4/+7
|
* Make some obvious consolidations in local declaration for readability.dteske2013-06-021-2/+1
|
* Standardize NULL initialization to be consistent.dteske2013-06-021-1/+1
|
* Improvements to whitespace and comments.dteske2013-06-021-1/+3
|
* Standardize the way functions build their arguments leading up to a dialogdteske2013-06-022-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | invocation. Specifically, "top-load" your arguments and in the order in- which they will be displayed. For example, many [if not all] widgets display information in the following order, top-to-bottom (visually): + backtitle (displayed behind the widget at top-left) + title (at the top of the `window') + prompt text (just below the title and above whatever widget you choose) + Depending on widget, _one_ of the following: - menu list - radio list - check list - text input box with initial text - [Xdialog(1)] 2x or 3x text input boxes - [dialog(1)] a multi-part form - progress bar - etc. (many more widget choices) + buttons (right below the selected widget) + [dialog(1)] the hline (displayed at bottom of `window') NOTE: Xdialog(1) accepts and silently ignores --hline When building local arguments for your dialog invocation, if the value can't be cleanly loaded into a local, add "# Calculated below" to the end of the local declaration while retaining the block order of argument declarations. Move other local declarations that are not associated with this top-loading the dialog arguments to right-above where they are first-used. Also, standardize on the names of the arguments. For example, always use $prompt (instead of sometimes $msg and sometimes $prompt); use $menu_list or $shell_list or $radio_list for those respective widgets; ad nauseum. While we're doing this, flush-out full arguments for many invocations that were passing NULL strings (making it unapparent if you were staring at this one invocation what argument that NULL string was supposed to represent). Last, while we're in startup/rcconf let's remove the unnecessary use of a GLOBAL (RCCONF_MENU_LIST) for the menu_list.
* Improve the dialog(1) API in dialog.subr by adding f_dialog_default_store()dteske2013-06-021-10/+14
| | | | | | | | | | and f_dialog_default_fetch(). Operating similar to functions introduced by SVN r251236 and r251242, these functions operate as a pair for helping track the default-item data (for the --menu, --checklist, and --radiolist widgets). This replaces the direct usage of a global to store the data with an abstract method for readability and to centralize the code.
* Similar to r251236, improve the portion of dialog(1) API in dialog.subrdteske2013-06-026-21/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | responsible for retrieving stored input (for the --inputbox and --password widgets). When we (Ron McDowell and I) developed the first version of bsdconfig, it used temporary files to store responses from dialog(1). That hasn't been true for a very long time, so the need to always execute some clean-up function is long-deprecated. The function that used to perform these clean- up routines for these widgets was f_dialog_inputstr(). We really don't need f_dialog_inputstr() for its originally designed purpose as all dialog invocations no longer require temporary files. Just as in r251236, redesign f_dialog_inputstr() in the following four ways: 1. Rename f_dialog_inputstr() to f_dialog_inputstr_fetch() 2. Introduce the new first-argument of $var_to_set to reduce forking 3. Create a corresponding f_dialog_inputstr_store() to abstract storage 4. Offload the sanitization to a new function, f_dialog_line_sanitize() It should be noted that f_dialog_line_sanitize() -- unlike its cousin from SVN r251236, f_dialog_data_sanitize() -- trims leading/trailing whitespace from the user's input. This helps prevent errors and common mistakes caused by the fact that the new cdialog implementation allows the right-arrow cursor key to go beyond the last byte of realtime input (adding whitespace at the end of the typed value). While we're centralizing the sanitization, let's rewrite f_dialog_input() while we're here to likewise reduce forking. The f_dialog_input() function now expects the first argument of $var_to_set instead of producing results on standard-out. These changes greatly improve readability and also improve performance.
* Improve portion of the dialog(1) API in dialog.subr responsible fordteske2013-06-015-32/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | retrieving stored data (for the --menu, --calendar, --timebox, --checklist, and --radiolist widgets). When we (Ron McDowell and I) developed the first version of bsdconfig, it used temporary files to store responses from dialog(1). That hasn't been true for some very long time, so the need to always store the return status of dialog(1) and then call some function to clean-up is long-deprecated. The function that used to do the clean-up was f_dialog_menutag(). We really don't need f_dialog_menutag() for its originally designed purpose, as all dialog invocations (even when in a sub-shell) do not use temporary files anymore. However, we do need to keep f_dialog_menutag() around because it still fills the need of being able to abstract the procedure for fetching stored data provided by functions that display the aforementioned widgets. In re-designing f_dialog_menutag(), four important changes are made: 1. Rename f_dialog_menutag() to f_dialog_menutag_fetch() 2. Introduce the new first-argument of $var_to_set to reduce number of forks 3. Create a corresponding f_dialog_menutag_store() to abstract the storage 4. Offload the sanitization to a new function, f_dialog_data_sanitize() NOTE: That last one is important. Not all functions need to store their data for later fetching, meanwhile every invocation of dialog should be sanitized (as we learned early-on in the i18n-effort -- underlying libraries will spit warnings to stderr for bad values of $LANG and since dialog outputs its responses to stderr, we need to sanitize every response of these warnings). These changes greatly improve readbaility and also improve performance by reducing unnecessary forking.
* Improve portion of the dialog(1) API in dialog.subr responsible fordteske2013-05-313-32/+41
| | | | | | | | | | | | | | | | | | | | calculating widget sizes. Instead of forking a sub-shell to calculate the optimum size for a widget, use a byRef style call-out to set variables in the parent namespace. For example, instead of: size=$( f_dialog_buttonbox_size title btitle msg ) $DIALOG --title title --backtitle btitle --msgbox msg $size The new API replaces the above with the following: f_dialog_buttonbox_size height width title btitle msg $DIALOG --title title --backtitle btitle --msgbox msg $height $width This reduces the number of forks, improves performance, and makes the code more readable by revealing the argument-order for widget sizing. It also makes performing minor adjustments to the calculated values easier as you no longer have to split-out the response (which required knowledge of ordering so was counter-intuitive).
* Centralize standard getopts arguments, both for convenience and to correctdteske2013-05-145-5/+5
| | | | | | | | | a bug in which certain combinations of arguments produced unexpected results such as `-dX' (now properly produces debugging and X11), `-XS' (now properly produces X11 in secure mode), `-df-' (enables debugging when reading a script from standard-input, etc. Multi-word variations such as `-d -X', `-X -S', `-d -f-', `-d -f -', etc. also work as expected. Also tested were variations in argument order, which are now working as expected.
* Prevent device.subr from auto-loading in the nameservers module.dteske2013-04-231-0/+3
| | | | | This module doesn't need device support (but device.subr is loaded indirectly through media/tcpip.subr which contains resolv stuff).
* Fix two bugs when setting up a plip interface. First, dhcp status was notdteske2013-04-221-1/+2
| | | | | being properly cleared each iteration of the loop. Second, values weren't properly quoted when sent to the editor function.
* UI improvements. First, implement --default-item whenever and whereverdteske2013-04-226-16/+47
| | | | | | | | possible to save keystrokes. Second, overhaul startup/rcdelete for much improved performance. Last, but not least, kill-off useage of --clear and implement --keep-tite in harmony to minimize jarring transitions. Also, fix local variable names where necessary while we're here with other minor comment-enhancements/typo-corrections.
* Add new flags `-d' (sets debug=1) and `-D file' (sets debugFile) anddteske2013-04-226-11/+15
| | | | | | improve debugging initialization. Also fixup USAGE statements while we're here. Also, change initialization of main program to _not_ change working directory, allowing the debugFile to be relative without confusion.
* Import media selection/preparation framework (sysinstall inspired). Makesdteske2013-02-2510-564/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | accessing files from various types of media nice and abstracted away from the wet-work involved in preparing, validating, and initializing those types of media. This will be used for the package management system module and other modules that need access to files and want to allow the user to decide where those files come from (either in a scripted fashion, prompted fashion, or any combination thereof). Heavily inspired by sysinstall and even uses the same reserved words so that scripts are portable. Coded over months, tested continuously through- out, and reviewed several times. Some notes about the changes: - Move network-setting acquisition/validation routines to media/tcpip.subr - The options screen from sysinstall has been converted to a dialog menu - The "UFS" media choice is renamed to "Directory" to reflect how sysinstall treats the choice and a new [true] "UFS" media choice has been added that acts on real UFS partitions (such as external disks with disklabels). - Many more help files have been resurrected from sysinstall (I noticed that some of the content seems a bit dated; I gave them a once-over but they could really use an update). - A total of 10 media choices are presented (via mediaGetType) including: CD/DVD, FTP, FTP Passive, HTTP Proxy, Directory, NFS, DOS, UFS, Floppy, USB - Novel struct/device management layer for managing the issue of passing more information than can comfortably fit in an argument list.
* Add new f_yesno/f_noyes wrapper functions (which take printf(1) syntax).dteske2013-01-143-12/+6
|
* Add missing dialog(1) arguments to internationalize "Help"-button label.dteske2013-01-141-0/+1
|
* Whitespace.dteske2012-12-281-0/+1
|
* Fix incorrect function name. s/[[:<:]]dialog_clear/f_&/dteske2012-12-281-1/+1
|
* Add more debugging to help with diagnosis of program-flow when needed.dteske2012-12-2513-0/+44
|
* Remove unnecessary duplicate initialization of the dialog(1) API (automaticallydteske2012-12-255-5/+0
| | | | bootstrapped on-include unless DIALOG_SELF_INITIALIZE is set to NO before-hand)
* Split dialog(1)-based validators for hostname/netmask into two, providingdteske2012-12-212-18/+74
| | | | | | transparent validators that can be used free of dialog(1) where needed. Syntax/return of the original dialog(1)-based validators remains unchanged.
* Remove unused include.dteske2012-12-211-1/+0
|
* New f_show_info() function for dialog(1) --infobox using printf(1) syntax.dteske2012-12-211-4/+2
|
* Use f_show_help() where printf(1) syntax is desired.dteske2012-12-216-60/+26
|
* Add much-needed dialog(1) --inputbox function for simplifying the process ofdteske2012-12-215-132/+21
| | | | requesting input from the user.
* Comments.dteske2012-11-271-2/+2
| | | | Approved by: adrian (co-mentor) (implicit)
* Split IP address validation routines and improve error detection for dotted-dteske2012-11-252-37/+91
| | | | | | quad notation in IPv6 addresses. Approved by: adrian (co-mentor) (implicit)
* Add IPv6 address-validation routine.dteske2012-11-242-2/+157
| | | | Approved by: adrian (co-mentor) (implicit)
* Replicate a feature from sysinstall documented indteske2012-11-165-5/+5
| | | | | | | | | | | | stable/9/usr.sbin/sysinstall/help/shortcuts.hlp (reproduced below): If /usr/sbin/sysinstall is linked to another filename, say `/usr/local/bin/configPackages', then the basename will be used as an implicit command name. To get a list of modules you can link to, see `bsdconfig -h' output. Approved by: adrian (co-mentor) (implicit)
OpenPOWER on IntegriCloud