| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
This is not "useless", as one may have non-default
setting for BINOWN in make.conf, and we still want
these to be installed setuid root in this case.
|
| |
|
|
|
|
| |
its failure mode, and will revisit it later.
|
|
|
|
|
|
|
|
| |
The remaining problem of converting highly incompatible pointer types
is done by "laundering" the value through a union.
This solves the problem (in my own mind) of how a "const char *" _ever_
actually gets a value in a WARNS=2 world.
|
|
|
|
| |
Discussed with: ru
|
|
|
|
| |
Forgot trailing newline in usage().
|
|
|
|
|
|
|
|
| |
This also reverts change in rev. 1.36 to the documented
style of writing usage().
PR: bin/29730
Submitted by: Joseph Mallett <jmallett@xMach.org>
|
| |
|
|
|
|
|
|
|
| |
WARNS=2 cannot be enable because of an unresolvable conflict in arg 2
of execv(). Document this in the Makefile.
Reviewed by: bde (su.c only)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
for authentication to PAM. This meens that WHEELSU-type logic can
now be effected in the pam.conf "su" configuration stack. While here,
clean up the mess that the code had assumed over years of hacking by
folks using different styles. ANSIfy.
There is more policy in here that can be handed over to PAM. This will
be revisited.
|
|
|
|
| |
Submitted by: Seth Kingsley <sethk@osd.bsdi.com>
|
|
|
|
| |
support can be gotten via PAM.
|
|
|
|
| |
support can be already obtained via PAM.
|
|
|
|
|
|
|
| |
The PAM_FAIL_CHECK and PAM_END macros in su.c came from the util-linux
package's PAM patches to the BSD login.c
Submitted by: "David J. MacKenzie" <djm@web.us.uu.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o In practice: the comment indicates that all but umask and
environmental variables of the users login class are applied when su
occurs, unless -m is used to specify a class. This was incorrect;
in practice, the uid, gids, resources, and priority were set, and
then resources and priority were selectively removed. This meant
that some aspects of the user context were not set, including handling
of login events (wtmp, utmp), as well as the path specified in
login.conf.
o I changed it so that the behavior is the same, but instead,
LOGIN_SETALL is used, and appropriate flags are removed, including
the LOGIN_SETLOGIN and LOGIN_SETPATH entries that were implicitly
not present before. I also updated the comment to reflect
reality, selecting reality as the "correct" behavior.
o This has the practical benefit that as new LOGIN_SET* flags are
introduced, they are supported by su unless specifically disabled.
For example, of a LOGIN_SETLABEL flag is introduced to support
MAC labels determined by the user's login class, then su no longer
has to be modified.
o It might be desirable to have su use LOGIN_SETPATH depending on
its command line parameters, as it might or might not be
considered part of the "environment".
Obtained from: TrustedBSD Project
|
| |
|
| |
|
|
|
|
|
| |
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
|
| |
|
|
|
|
|
|
|
|
| |
happened as it was working around problems elsewhere (ie: binutils/ld
not doing the right thing according to the ELF design). libcrypt has
been adjusted to not need the runtime -lmd. It's still not quite right
(ld is supposed to work damnit) but at least it doesn't impact all the
users of libcrypt in Marcel's cross-build model.
|
|
|
|
|
| |
smart because it will definitely get it wrong. This popped up during
cross-linking.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
(emulate the 'd' linker (?)). This was most harmful for the NOSHARED=yes
case since libskey.o isn't linked to libmd.a.
Fixed the usual disorder of DPADD and LDADD, and some tab lossage.
|
|
|
|
|
|
| |
PR: 10115
Reported by: Gene Skonicki <gene@cif.rochester.edu>
Requested by: jdp
|
| |
|
|
|
|
| |
Reviewed By: eivind
|
| |
|
|
|
|
|
| |
PR: bin/7986
Submitted by: Dan Nelson <dnelson@emsphone.com>
|
| |
|
|
|
|
|
|
|
| |
linkage is needed for the NOSHARED=YES case, so it is simplest to
never depend on the automagic linkage for elf shared libraries.
Reviewed by: jdp
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
being invoked. Add example that clarifies usage of "-c".
PR: 6859
|
|
|
|
| |
Abort if given uname is > MAXLOGNAME-1
|
|
|
|
|
|
|
|
|
| |
group is 0 in /etc/passwd even if they aren't listed
as a member in /etc/group. This is more inline with
what the group manpage says.
PR: 6696
Submitted by: Max Euston <meuston@jmrodgers.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Quieten -Wall a bit.
From Joe Traister:
The previous patch did not propogate the KRBTKFILE environment variable
into the new environment when -l is given to su, making it impossible
for kdestroy to find the ticket file. This patch corrects that problem
as well as the original segfault problem.
(Fixes PR 3903)
|
|
|
|
|
|
| |
su manpage ambiguous regarding command prompt
Submitted by: sheldonh@iafrica.com
|
|
|
|
| |
A
|
|
|
|
|
|
|
|
| |
Submitted by: Josh Gilliam
Closes PR's: 4429, 4431-4438
PS: He has agreed to submit all contrib fixes back to the original author.
|
|
|
|
|
| |
PR: bin/3206
Submitted by: blank@fox.uni-trier.de
|
| |
|
| |
|